Repository navigation
fix(flags): preserve integer map key brackets - #528
Open
terminalchai wants to merge 1 commit into
Open
terminalchai wants to merge 1 commit into
terminalchai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetStringToIntandGetStringToInt64round-trip values through their bracket-wrappedString()representation. The converters currently usestrings.Trim(val, "[]"), which also removes brackets belonging to the first key: a stored key"[name]"comes back as"name]".Remove only one leading and trailing wrapper bracket in each converter. Regression tests cover both public getters with defaults, explicit and repeated Set calls, bracketed/empty/ordinary keys, multiple entries, and integer limits. The tests fail against the original converters and pass with the fix.
Related to #413's bracket-stripping problem, but this change is limited to integer-map getters. #414 handles StringToString, and #515's integer-map sorting change is independent.
Full tests, race tests, Windows 386 tests, vet, build, and changed-file formatting pass on Go 1.26.1.
golangci-lint2.15.0 reports zero new issues; its full run reports three pre-existing gofmt findings in unchangedbool.go,bool_func.go, andbool_slice.go, reproduced on pristine upstreamd26a4dc.Prepared with AI assistance and separate specification and code reviews.