Repository navigation
Fix type identification and mismatch checks for text flags - #526
Merged
tomasaschan merged 1 commit intoOct 20, 2026
Merged
Conversation
dewanshshekhar
marked this pull request as ready for review
October 19, 2026 20:16
tomasaschan
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Text flags currently use
reflect.Type.Name()on their pointer values. Pointers are unnamed, so a*time.Timeflag reports an empty type andGetTextalso accepts an unrelated pointer implementingencoding.TextUnmarshaler. That output can be modified instead of receiving the intended type-mismatch error.Use
reflect.Type.String()consistently for the flag and requested output type. This also gives text flags a usable type label, such as*time.Time, in help output. Add regressions for the label and for rejecting a different output type without modifying it; the existing time round-trip tests continue to pass.Validation on Go 1.27.2, Windows amd64:
go test -p 2 -count=1 ./...passes.go vet -p 2 ./...,gofmt, andgit diff --checkpass.Prepared and tested with OpenAI Codex assistance. This is a draft for human review.