Repository navigation
Reject IPv6 addresses as IPv4 masks - #524
Merged
tomasaschan merged 1 commit intoOct 19, 2026
Merged
Conversation
|
|
tomasaschan
approved these changes
Oct 19, 2026
Collaborator
|
Merged despite the failing lint check; that should have been addresed by #525. If not, I'll follow up with a fix after the main branch build fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
ParseIPv4Mask("2001:db8::1")currently succeeds as00000001: it takes the last four bytes of any IP address. Consequently, an IPv6 value silently changes anIPMaskflag instead of returning a parse error.Require
To4()before constructing the mask. Keep dotted IPv4, hexadecimal masks and IPv4-mapped addresses working, and leave the flag unchanged after invalid input.Both new regression tests failed before the fix.
go test ./... -count=1,go vet ./...and gofmt pass on Windows/Go 1.27.