Repository navigation
fix(credentials): surface host-list query failures instead of returning an empty success #48
Description
Finding
GET /admin/api/settings/hosts returns HTTP 200 with [] when the backing credential query fails. Users cannot distinguish "no configured Git hosts" from "credential metadata could not be read."
Related reproducer: #45. This issue covers error propagation/observability rather than duplicating the full database-compatibility migration.
Observed evidence
At source revision 41ec093a745f1c0277893dc8f758b96b216c970f, a fresh full-PostgreSQL deployment with authentication enabled initialized its PostgreSQL schema and admin key. An authenticated host-list request returned:
GET /admin/api/settings/hosts -> HTTP 200
[]
The application logged:
Failed to list git host credentials: no such table: git_host_credentials
Root cause:
- list_git_host_credentials() catches the query failure and returns an empty list.
- The API has an error response, but never reaches it because the service swallowed the exception.
Expected outcome
- Propagate or explicitly represent credential-store query failures so the API returns a visible non-success error.
- Reserve HTTP 200 with
[]for a successful query with no rows. - Preserve existing credential masking and avoid exposing tokens, connection strings, or private host information in errors.
Acceptance checks
- A successfully queried empty credential store returns HTTP 200 with
[]. - Missing-table, unavailable-database, and query-failure cases produce a sanitized error response, not an empty success.
- A successful non-empty response retains existing credential masking.
Activity
spelech commentedon Oct 27, 2026
Triage & Implementation Brief
1. Scope & Effort
2. Root Cause & Context
In
app/services/database/credentials.py::list_git_host_credentials(), any database query failure is caught withexcept Exception: return []. The API endpoint inapp/api/routers/settings.pyreceives an empty list and returns HTTP 200, making database errors indistinguishable from having zero configured credentials.3. Implementation Plan
except Exception: return []block inlist_git_host_credentials().app/api/routers/settings.py.settings.pyto catch query exceptions and return HTTP 500 with sanitized diagnostics (ensuring tokens or connection strings are never leaked).[]strictly for successful queries that find zero rows.4. Acceptance Criteria
[].google-labs-jules commentedon Oct 27, 2026
Jules is on it. When finished, you will see another comment and be able to review a PR.
google-labs-jules commentedon Oct 27, 2026
Ready for a review! A PR has been created.