Report the Merge Images check on dependabot pull requests - #73
Merged
Merged
Conversation
The merge job was skipped for dependabot with a job-level `if`. GitHub does
not evaluate the name of a job skipped that way, so the check came out as
the literal `Merge / Merge Images${{ ... }}` instead of `Merge / Merge
Images`. A ruleset requiring that check never saw it, and every dependabot
pull request stayed blocked even though both builds had passed.
The job now always runs and skips its steps instead, reporting success
under its real name. A new `push` input controls it, defaulting to pushing
except for dependabot, the same as build.yml. merge-go-cli.yml forwards it
like build-go-cli.yml does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
merge.ymlno longer skips its job for dependabot. A job skipped by itsifis reported under its unevaluated name (Merge / Merge Images${{ ... }}), so a requiredMerge / Merge Imagescheck never passed (i.e. Bump hashicorp/packer from light-1.16.0 to light-1.16.1 packer#46).pushinput controls this and defaults to pushing, except for dependabot, the same asbuild.yml.merge-go-cli.ymlforwards it.