Repository navigation
Conversation
- CG-LIVING - CG-SNAPSHOT Include the cgbgStatus and new CG assets (base.css, cg-spec.css, dark.css, cg-fixup.js and cg-metadata.js) for these new profiles. Introduce <meta> tags required by the new profiles. Run some validation.
…ata + introduce new boilerplates depending on the type of CG specs
deniak
force-pushed
the
feat/cg-redesign-identity-assets
branch
from
October 6, 2026 05:38
8585b0b to
a938dcf
Compare
…oscript>' parses its content as raw text
marcoscaceres
requested review from
sidvishnoi
and
a balanced review from Copilot
October 6, 2026 09:36
Contributor
|
@sidvishnoi, do you mind reviewing this first if you have cycles. If you're busy, happy to dive in. |
| const COMMUNITY = "https://www.w3.org/community/"; | ||
| const INCUBATION = "https://incubation.w3.org/"; | ||
|
|
||
| const chevron = () => |
Contributor
There was a problem hiding this comment.
this is only called once, so we can probably just inline it. Does this need any ARIA stuff?
| @@ -0,0 +1,52 @@ | |||
| <!doctype html> | |||
Contributor
There was a problem hiding this comment.
Not sure we should add this example at all to be honest.
| * @param {string} noScriptText | ||
| * @param {"div" | "li"} as | ||
| */ | ||
| export function region(name, noScriptText, as = "div") { |
Contributor
There was a problem hiding this comment.
Maybe more clear:
Suggested change
| export function region(name, noScriptText, as = "div") { | |
| export function region(name, noScriptText, elementName = "div") { |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Type-qualified and joint group configurations currently generate incorrect links and header markup.
Review effort: Balanced
Findings: 4
Open (6)
What changed in this PR
Adds redesigned CG-LIVING and CG-SNAPSHOT Community Group profiles with dedicated headers, metadata, assets, and supporting sections.
Changes:
- Adds CG profile configuration, validation, templates, and pipeline modules.
- Integrates external CG assets and metadata regions.
- Adds comprehensive integration and unit coverage plus an example document.
| File | Description |
|---|---|
tests/unit/w3c/cg-headers-spec.js |
Tests snapshot-index URL generation. |
tests/spec/w3c/cg-spec.js |
Covers profiles, metadata, assets, and variants. |
src/w3c/templates/cg-sotd.js |
Adds the redesigned minimal SotD. |
src/w3c/templates/cg-headers.js |
Builds redesigned CG headers. |
src/w3c/style.js |
Selects CG-specific assets. |
src/w3c/headers.js |
Registers statuses and templates. |
src/w3c/defaults.js |
Validates new configuration options. |
src/w3c/cg-spec.js |
Emits CG metadata identity. |
src/w3c/cg-sections.js |
Adds involvement and usage sections. |
src/w3c/cg-assets.js |
Loads and restores CG assets. |
src/type-helper.d.ts |
Types the new configuration. |
profiles/w3c.js |
Registers the new modules. |
examples/cg-living.html |
Demonstrates the living profile. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+33
to
+34
| const joinURL = | ||
| typeof conf.group === "string" ? `${COMMUNITY}${conf.group}/join` : null; |
| // TODO: | ||
| // - `conf.group` is an array for joint publications | ||
| // - `conf.group` is an id | ||
| const group = typeof conf.group === "string" ? conf.group.split("/")[0] : ""; |
Comment on lines
+272
to
+273
| the Contributors to the ${titleNodes} Specification, published by the | ||
| <a href="${conf.wgURI}">${conf.wg}</a> under the ${agreement} |
Comment on lines
+12
to
+14
| it("uses the group's own short name from a type-qualified group", () => { | ||
| expect(snapshotsIndex({ group: "wicg/cg", shortName: "foo" })).toBe( | ||
| "https://incubation.w3.org/groups/wicg/specs/#foo" |
Comment on lines
+198
to
204
| if ( | ||
| ![...cgStatus, ...cgRedesignStatus, "unofficial", "UD"].includes( | ||
| specStatus | ||
| ) | ||
| ) { | ||
| const msg = docLink`W3C Community Group documents can't use \`"${specStatus}"\` for the ${"[specStatus]"} configuration option.`; | ||
| const supportedStatus = codedJoinOr(cgStatus, { quotes: true }); |
Comment on lines
+179
to
+181
| The text of this specification and the status information support | ||
| for this specification are expected to change in place at this | ||
| address. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CG-LIVINGandCG-SNAPSHOTfollowing the upcoming updates with the CG spec lifecycle. These profiles use different headers (see mockups) and rely on assets and metadata. The existing profilesCG-DRAFTandCG-FINALremain untouched.cgMaturity(draft,transferredorunmaintained) andtransferredTo(only applies ifcgMaturity = transferred)Description of the new processing files:
src/w3c/templates/cg-headers.jsbuilds the redesign headers for the 4 variants (draft, transferred, unmaintained and snapshot) and adds the different containers (with adata-cg-regionattribute) thatcg-metadatafills when the spec loadssrc/w3c/cg-sections.jsadds the "Get involved" and "Usage guidance" sectionssrc/w3c/cg-spec.jsemits three new tags thatcg-metadatarelies on to fetch the appropriate metadatasrc/w3c/templates/cg-sotd.jsreduces the SotD to what the editors wrote (we do not have required paragraphs for the new profiles)Some URLs are still subject to change so it's not ready to be merged.