Conversation
It is deployed from another repository of its own now. Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR removes the repository-owned deployment of the public schema registry.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1676 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/getting-started.md">
<violation number="1" location="docs/getting-started.md:189">
P3: The reformatted tip sentence now ends without a period after `baseUri` (the diff dropped the `.` that previously terminated this sentence before the removed link text). Add the closing period.</violation>
</file>
Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.
Re-trigger cubic
| schemas from many third-party sources using `baseUri`. [Find the | ||
| configuration file | ||
| here](https://github.com/sourcemeta/one/blob/main/enterprise/e2e/public/one.json) | ||
| schemas from many third-party sources using `baseUri` |
There was a problem hiding this comment.
P3: The reformatted tip sentence now ends without a period after baseUri (the diff dropped the . that previously terminated this sentence before the removed link text). Add the closing period.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At docs/getting-started.md, line 189:
<comment>The reformatted tip sentence now ends without a period after `baseUri` (the diff dropped the `.` that previously terminated this sentence before the removed link text). Add the closing period.</comment>
<file context>
@@ -184,11 +184,9 @@ base, and the indexer would report an error.
- schemas from many third-party sources using `baseUri`. [Find the
- configuration file
- here](https://github.com/sourcemeta/one/blob/main/enterprise/e2e/public/one.json)
+ schemas from many third-party sources using `baseUri`
### Next Steps
</file context>
Suggested change
| schemas from many third-party sources using `baseUri` | |
| schemas from many third-party sources using `baseUri`. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Benchmark (community)
Details
| Benchmark suite | Current: ca7e53d | Previous: ea53bde | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
194 ms |
254 ms |
0.76 |
Add one schema (100 existing) |
33 ms |
44 ms |
0.75 |
Add one schema (1000 existing) |
103 ms |
98 ms |
1.05 |
Add one schema (10000 existing) |
839 ms |
720 ms |
1.17 |
Update one schema (1 existing) |
26 ms |
31 ms |
0.84 |
Update one schema (101 existing) |
34 ms |
40 ms |
0.85 |
Update one schema (1001 existing) |
100 ms |
99 ms |
1.01 |
Update one schema (10001 existing) |
812 ms |
744 ms |
1.09 |
Cached rebuild (1 existing) |
11 ms |
10 ms |
1.10 |
Cached rebuild (101 existing) |
11 ms |
15 ms |
0.73 |
Cached rebuild (1001 existing) |
36 ms |
40 ms |
0.90 |
Cached rebuild (10001 existing) |
277 ms |
308 ms |
0.90 |
Index 100 schemas |
418 ms |
516 ms |
0.81 |
Index 1000 schemas |
1706 ms |
1467 ms |
1.16 |
Index 10000 schemas |
20667 ms |
12462 ms |
1.66 |
Index 10000 schemas (custom meta-schema) |
18269 ms |
15534 ms |
1.18 |
Index 10000 schemas ($ref fan-out) |
17892 ms |
15664 ms |
1.14 |
test/e2e/html: Schema Fetch (p50) |
307 us |
413 us |
0.74 |
test/e2e/html: Schema Fetch (p99) |
384 us |
490 us |
0.78 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
There was a problem hiding this comment.
Benchmark (enterprise)
Details
| Benchmark suite | Current: ca7e53d | Previous: ea53bde | Ratio |
|---|---|---|---|
Add one schema (0 existing) |
260 ms |
339 ms |
0.77 |
Add one schema (100 existing) |
101 ms |
125 ms |
0.81 |
Add one schema (1000 existing) |
159 ms |
183 ms |
0.87 |
Add one schema (10000 existing) |
865 ms |
936 ms |
0.92 |
Update one schema (1 existing) |
89 ms |
128 ms |
0.70 |
Update one schema (101 existing) |
100 ms |
129 ms |
0.78 |
Update one schema (1001 existing) |
158 ms |
183 ms |
0.86 |
Update one schema (10001 existing) |
909 ms |
844 ms |
1.08 |
Cached rebuild (1 existing) |
10 ms |
14 ms |
0.71 |
Cached rebuild (101 existing) |
15 ms |
17 ms |
0.88 |
Cached rebuild (1001 existing) |
37 ms |
46 ms |
0.80 |
Cached rebuild (10001 existing) |
282 ms |
345 ms |
0.82 |
Index 100 schemas |
558 ms |
636 ms |
0.88 |
Index 1000 schemas |
1355 ms |
1692 ms |
0.80 |
Index 10000 schemas |
14932 ms |
13409 ms |
1.11 |
Index 10000 schemas (custom meta-schema) |
15270 ms |
15042 ms |
1.02 |
Index 10000 schemas ($ref fan-out) |
16447 ms |
16819 ms |
0.98 |
enterprise/e2e/auth: Schema Anonymous (p50) |
298 us |
374 us |
0.80 |
enterprise/e2e/auth: Schema Anonymous (p99) |
374 us |
481 us |
0.78 |
enterprise/e2e/auth: Schema API Key Identity (p50) |
302 us |
380 us |
0.79 |
enterprise/e2e/auth: Schema API Key Identity (p99) |
389 us |
483 us |
0.81 |
enterprise/e2e/auth: Schema API Key SHA256 (p50) |
307 us |
388 us |
0.79 |
enterprise/e2e/auth: Schema API Key SHA256 (p99) |
384 us |
586 us |
0.66 |
enterprise/e2e/auth: Schema JWT (p50) |
414 us |
526 us |
0.79 |
enterprise/e2e/auth: Schema JWT (p99) |
506 us |
662 us |
0.76 |
test/e2e/html: Schema Fetch (p50) |
304 us |
381 us |
0.80 |
test/e2e/html: Schema Fetch (p99) |
359 us |
472 us |
0.76 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is deployed from another repository of its own now.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com