Upgrade Sourcemeta dependencies - #941
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Sourcemeta Core and Blaze dependencies. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
| if (callback) { | ||
| auto location{to_weak_pointer(container)}; | ||
| location.push_back(std::cref(key)); | ||
| callback(identifier, location); |
There was a problem hiding this comment.
[vendor/core/src/core/jsonschema/bundle.cc:90] The callback's WeakPointer is documented as a pointer into the bundled root, but its final token references the local key string instead; retaining the callback argument (or a copy of it) leaves a dangling reference when embed_schema returns. This makes the new callback API unsafe for clients that collect embedding locations.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com