Upgrade Sourcemeta dependencies - #940
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR upgrades the vendored Sourcemeta Core and Blaze dependencies.
🤖 Was this summary useful? React with 👍 or 👎 |
| /// Get the number of bytes accumulated so far | ||
| [[nodiscard]] SOURCEMETA_FORCEINLINE auto size() const noexcept | ||
| -> std::size_t { | ||
| return static_cast<std::size_t>(this->cursor_ - this->begin_); |
There was a problem hiding this comment.
HTMLBuffer starts with both begin_ and cursor_ null, so this pointer subtraction is undefined before its first allocation (and again after take()). grow() calls size() on the first append, while str() and write() can call it on an empty writer, so ordinary Markdown/HTML rendering invokes UB and fails under UBSan.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com