Skip to content

Cover Draft 3 identifier nesting in the evaluator test suite - #1092

Merged
jviotti merged 1 commit into
sourcemeta:mainfrom
Vansh-kap-98:draft3-id-test-batch
Sep 25, 2026
Merged

jviotti merged 1 commit into
sourcemeta:mainfrom
Vansh-kap-98:draft3-id-test-batch

Conversation

@Vansh-kap-98

@Vansh-kap-98 Vansh-kap-98 commented Sep 25, 2026 •

Copy link
Copy Markdown
Collaborator

103 cases added to test/evaluator/evaluator_draft3.json, covering the identifier nesting shapes we had no coverage for:

  • cycles across identifier scopes: mutual, three-scope, self-recursive, and one mixing a relative hop with an absolute return hop
  • identifiers under disallow, extends, dependencies, additionalProperties and patternProperties rather than properties
  • five-level chains alternating relative and absolute identifiers, where an absolute one mid-chain resets the base
  • one target reached by two spellings, and the same anchor name declared in two resources
  • $ref siblings, which Draft 3 ignores
  • identifiers combined with type unions, including a union inside a union and an identifier on both the union and the keyword it distributes
    Plus regression cases for bugs found while writing these: the required marker, $ref siblings beside extends, and definitions relocated with a reference.

Review in cubic

Add 103 cases covering cycles across identifier scopes, identifiers under disallow, extends, dependencies, additionalProperties and patternProperties, deep alternating chains, one target reached by two spellings, colliding anchors, $ref siblings, and identifiers combined with type unions.

Signed-off-by: Vansh <officialbusiness9818@gmail.com>
@Vansh-kap-98
Vansh-kap-98 marked this pull request as ready for review September 25, 2026 12:29
@augmentcode

augmentcode Bot commented Sep 25, 2026

Copy link
Copy Markdown

This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic

@jviotti jviotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good!

@jviotti
jviotti merged commit 15c3d3e into sourcemeta:main Sep 25, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants