Cover Draft 3 identifier nesting in the evaluator test suite - #1092
Merged
Merged
Conversation
Add 103 cases covering cycles across identifier scopes, identifiers under disallow, extends, dependencies, additionalProperties and patternProperties, deep alternating chains, one target reached by two spellings, colliding anchors, $ref siblings, and identifiers combined with type unions. Signed-off-by: Vansh <officialbusiness9818@gmail.com>
Vansh-kap-98
marked this pull request as ready for review
September 25, 2026 12:29
|
This pull request is abnormally large and would use a significant amount of tokens to review. If you still wish to review it, comment "augment review" and we will review it. |
There was a problem hiding this comment.
No issues found across 1 file
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
103 cases added to
test/evaluator/evaluator_draft3.json, covering the identifier nesting shapes we had no coverage for:disallow,extends,dependencies,additionalPropertiesandpatternPropertiesrather thanproperties$refsiblings, which Draft 3 ignoresPlus regression cases for bugs found while writing these: the
requiredmarker,$refsiblings besideextends, anddefinitionsrelocated with a reference.