fix/links: Fix broken heading links (21 reworded, admin) - #1868
Open
marcleblanc2 wants to merge 2 commits into
Open
fix/links: Fix broken heading links (21 reworded, admin)#1868marcleblanc2 wants to merge 2 commits into
marcleblanc2 wants to merge 2 commits into
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a07623-9d65-7356-96b8-2bebb31ffa5a Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
marcleblanc2
changed the title
marcleblanc2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear FE-499: Fix doc site issues
Smaller, more easily reviewed subset of fixes from #1861
#anchorlinks underdocs/admin/whose target heading was reworded. The section still exists; the link now uses the current heading's slug.Review: for each row, the new heading should be the same topic as the old anchor's words. Rows where the heading was replaced rather than renamed (e.g. several anchors collapsed onto one
#configurationor#upgrade-typessection) are the ones worth a second look.Left alone on purpose: anchors that name a JSON-schema key (
/admin/repo/perforce#rateLimit,#depots,#p4-user,#p4-passwd); the schema renderer emits no per-key ids, so those get a separate fix.One to note:
#library-examples→#examples-2indocs/admin/config/batch-changes.mdx— the page has several## Examplesheadings, so github-slugger numbers them.Checker findings (
npm run check-links -- --check-anchors, from #1858, with its heading-slug fix): 278 on main → 257 on this branch.Verification
The docs site serves its not-found page with HTTP 200 (fix in progress), so status codes prove nothing. Instead, every changed link was fetched on this PR's Vercel preview and the rendered HTML checked for two
ids: the target page's own first heading (taken from its MDX source — the 404 page never has it) and the link's#fragment. Script:node dev/verify-links-live.mjs --site <preview-url>, coming in #1858.Old links point at the current production site so you can see the breakage; new links point at the preview and land on the heading.
Checked 21 changed links against https://sourcegraph-docs-git-fix-reworded-a-2d2500-sourcegraph-f8c71130.vercel.app: 21 resolve, 0 fail.
Page rendered = the target page's first heading id is present (the 404 page never has it); Anchor = the #fragment is an id on the page. Old links point at the current site.
All 21 links
docs/admin/auth/index.mdx/admin/code-hosts/github#repository-syncing/admin/code-hosts/github#selecting-repositories-to-syncdocs/admin/auth/index.mdx#how-to-control-user-sign-up#how-to-control-user-sign-up-and-sign-in-with-github-auth-providerdocs/admin/auth/saml/microsoft-adfs.mdx/admin/auth/saml/#saml-troubleshooting/admin/auth/saml#troubleshootingdocs/admin/code-hosts/bitbucket-server.mdx/integration/bitbucket-server#sourcegraph-bitbucket-server-plugin/integration/bitbucket-server#sourcegraph-bitbucket-plugindocs/admin/code-hosts/bitbucket-server.mdx/integration/bitbucket-server#sourcegraph-bitbucket-server-plugin/integration/bitbucket-server#sourcegraph-bitbucket-plugindocs/admin/code-hosts/bitbucket-server.mdx/integration/bitbucket-server#sourcegraph-bitbucket-server-plugin/integration/bitbucket-server#sourcegraph-bitbucket-plugindocs/admin/code-hosts/gerrit.mdx#configure-gerrit-as-code-host-connection#configure-gerrit-as-a-code-host-connectiondocs/admin/code-hosts/gerrit.mdx#add-gerrit-as-an-authnetication-provider#add-gerrit-as-an-authentication-providerdocs/admin/code-hosts/github.mdx/admin/config/batch-changes#commit-signing-for-github/admin/config/batch-changes#commit-signing-with-github-appsdocs/admin/code-hosts/github.mdx/admin/auth/#requiredssoOrgs/admin/auth#githubdocs/admin/code-hosts/github.mdx/admin/webhooks/incoming#user-permissions/admin/webhooks/incoming#githubdocs/admin/code-hosts/github.mdx/admin/webhooks/incoming#user-permissions/admin/webhooks/incoming#githubdocs/admin/code-hosts/github.mdx/admin/webhooks/incoming#user-permissions/admin/webhooks/incoming#githubdocs/admin/config/batch-changes.mdx#library-examples#examples-2docs/admin/how-to/index.mdx/admin/how-to/remove-repo#manually-purge-deleted-repository-data-from-disk/admin/how-to/remove-repo#remove-corrupted-repository-data-from-sourcegraphdocs/admin/permissions/index.mdx/admin/repo/perforce#repository-permissions/admin/repo/perforce#repository-permissions-betadocs/admin/permissions/webhooks.mdx/admin/webhooks/incoming#user-permissions/admin/webhooks/incoming#githubdocs/admin/scim.mdx#setting-up-okta-as-the-idp#configuring-scim-for-oktadocs/admin/security-event-logs.mdx/admin/audit-log#excessive-audit-logging/admin/audit-log#configuringdocs/admin/webhooks/incoming.mdx/integration/bitbucket-server#sourcegraph-bitbucket-server-plugin/integration/bitbucket-server#sourcegraph-bitbucket-plugindocs/admin/webhooks/incoming.mdx/integration/bitbucket-server#sourcegraph-bitbucket-server-plugin/integration/bitbucket-server#sourcegraph-bitbucket-pluginAmp threads