Repository navigation
Fix prefetch handling and validate data URLs - #276
Merged
Merged
Conversation
So far, we had always some errors in the logs, which seems to come from bots crawling rebenchdb. The id parsing is now validating input, and produces proper 404s. Node.js turns header names into lower-case to be fully case insensitive, but I got this previously wrong. Fixed now. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Needed during development on Ubuntu. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js lower-cases all header names, which I did not previously consider.
So, hopefully that now works as intended.
And, I was not checking that ids are proper integers.
So, I got errors like the following in the logs:
This should now be fixed.
On Ubuntu, I needed to allow the install script for the file watcher.