Repository navigation
Add more thorough testing for boxplots - #274
Merged
Merged
Conversation
I want to replace chart.js at some point by just generating SVG. Given that our boxplots are fairly simple, this should be making them much more compact. But, before that, let’s improve test coverage. Signed-off-by: Stefan Marr <git@stefan-marr.de>
Corrindates in SVG files may be slightly different, because of floating point instruction ordering causing different errors. This ignores difference within a certain tolerance. We grab all numbers from the SVG and compare them with the expected one, allowing for a tolerance. Signed-off-by: Stefan Marr <git@stefan-marr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is adds more direct testing of boxplot rendering with concrete examples.
The goal is to cover the rendering a bit more, since I want to replace it eventually.
Currently, this is one of the parts of the report rendering that takes the most time, and the SVGs are very large, too.