Repository navigation
SK-3139: Implement query, get_tokens, upload_files, delete_files in flowvault - #283
Merged
saileshwar-skyflow merged 4 commits intoOct 6, 2026
Conversation
…lowvault Add four unary operations to the Python flowvault SDK, mirroring the design doc and the existing get/detokenize patterns: - query: read-only SQL SELECT (QueryRequest/QueryResponse); failures are thrown. - get_tokens: value -> token lookup for deterministic token groups, with per-record results. - upload_files: orchestrated two-phase upload (fetch a signed URL per column, then PUT the bytes), accepting file_path/base64/file_object input and returning a per-column upload status. The signed URL is not surfaced. - delete_files: delete files from file columns by skyflow_id or unique_values. Includes base classes in common, validators, message-catalog entries, the generated files wire client, VaultClient accessors (get_query_api, get_files_api, put_signed_url), data-class exports, runnable samples, and README updates. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
…eline
- version.py: the Fern regeneration had overwritten the repo customization with
metadata.version("skyflow.generated.rest"), which has no installed distribution
and raised PackageNotFoundError -- breaking `unittest discover` (and all imports
of skyflow.generated.rest) in CI. Restore the lookup of "skyflow-flowvault-python"
with the PackageNotFoundError -> "0.0.0" fallback.
- api-report/skyflow.api.json: refresh the public-API contract baseline to include
the new query / get_tokens / upload_files / delete_files surface (additive only;
no members removed).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
Public API contract change (
|
Replace the magic 200/300 in upload_files' per-column PUT status check with named HTTP_STATUS_OK / HTTP_STATUS_MULTIPLE_CHOICES constants, matching the repo's no-magic-values lint rule. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
…iles Cover the four new operations across controller, validations, data classes, and client accessors (85 new tests). Exercises happy paths, per-record error handling, the two-phase upload orchestration (file_path/base64/file_object, PUT success/failure/skip, content-type inference), and request/response mapping. New source is ~98% covered, satisfying the codecov patch gate. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
saileshwar-skyflow
changed the base branch from
main
to
flowvault-release/26.10.0
October 6, 2026 10:25
yaswanth-pula-skyflow
approved these changes
Oct 6, 2026
skyflow-bharti
approved these changes
Oct 6, 2026
saileshwar-skyflow
merged commit Oct 6, 2026
e38eae2
into
flowvault-release/26.10.0
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four new unary operations to the Python flowvault SDK (
skyflow-flowvault-python), mirroring the design doc and the existingget/detokenizepatterns:vault().query()SELECT(≤25 rows, page viaOFFSET). No per-record results — any failure is thrown;request_idalways populated.vault().get_tokens()vault().upload_files()POST /v2/files/upload), thenPUTthe bytes. Acceptsfile_path/base64/file_object; per-columnUPLOADED/FAILED/SKIPPED. The signed URL is used internally and not returned.vault().delete_files()skyflow_idorunique_values(POST /v2/files/delete).What's included
flowvault/skyflow/vault/data/for each operation (request/record/column/options/response) plus base classes incommon/vault/data/(mirroring the Java layout).validate_query_request,validate_get_tokens_request,validate_upload_files_request,validate_delete_files_request) and message-catalog entries (Error / Info / ErrorLogs)._vault.py; VaultClient accessorsget_query_api(),get_files_api(), andput_signed_url().generated/rest/files/) and file request/response types.query_records.py,get_tokens.py,upload_files.py,delete_files.py) and README / samples-README updates.FileUploadStatusenum.Testing
common,flowvault,skyvault.credentials.jsontest fixture not present in this checkout — unrelated to this change).commonand the new files API.Notes
upload_filesis sequential in v1; the async virus-scanfileStatusis read later viaget().signed_urlfrom the per-column upload result.