Repository navigation
Fix EarthSatellite.epoch float-day truncation - #1143
Closed
shaneraphel wants to merge 1 commit into
Closed
shaneraphel wants to merge 1 commit into
shaneraphel wants to merge 1 commit into
Conversation
Member
|
Thanks for looking into this, I'll hopefully get the chance to look at this in detail within the next week! |
Member
|
Since d618ee9 fixed the underlying issue with a slightly different approach, I'm going to close this PR. But thanks for the work to find a fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1141.
EarthSatellite.epochis documented as the TLE epoch. The current path packssatrec.epochdays(and thefrom_satrecJulian-date fraction) into a single float day argument ofts.utc, which truncates the fraction. That offset is up to ~34 µs and moves a LEO evaluated at its own epoch by ~25 cm.from_ommalready usests._utc_jdand is not rewritten.Pass the day fraction as seconds:
and the same on
from_satrec. Leap seconds are not rewritten.Measured on skyfield 1.55 / sgp4 2.27, TLE 55910
23076.01808579, builtin timescale:EarthSatellite(line1, line2)from_satrects._utc_jd(OMM control)