Skip to content

fix: Filesystem backup API requires volume name #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nterbogt merged 2 commits into from
Oct 1, 2026
Merged

fix: Filesystem backup API requires volume name #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af12877
API requires volumeName. We weren't passing it in
nterbogt Oct 1, 2026
fd07b23
Improving documentation
nterbogt Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cmd/skpr/filesystem/backup/create/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,27 @@ var (
cmdLong = `Create a filesystem backup of an environment.`

cmdExample = `
# Create a filesystem backup of dev.
skpr filesystem backup create dev
# Create a filesystem backup of public mount on dev.
skpr filesystem backup create dev public

# Create and wait for a filesystem backup.
skpr filesystem backup create dev --wait`
# Create and wait for a filesystem backup of private mount.
skpr filesystem backup create dev private --wait`
)

// NewCommand creates a new cobra.Command for 'create' sub command
func NewCommand() *cobra.Command {
command := v1create.Command{}

cmd := &cobra.Command{
Use: "create <environment>",
Args: cobra.ExactArgs(1),
Use: "create <environment> <id>",
Args: cobra.ExactArgs(2),
DisableFlagsInUseLine: true,
Short: "Create a filesystem backup",
Long: cmdLong,
Example: cmdExample,
RunE: func(cmd *cobra.Command, args []string) error {
command.Environment = args[0]
command.VolumeName = args[1]
return command.Run(cmd.Context())
},
}
Expand Down
Loading