Conversation
badrogger
requested review from
a team,
dmytrotkk and
kladkogex
as code owners
September 22, 2026 18:19
dmytrotkk
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces SGX client certificate management commands to the SKALE Node CLI and Fair Node CLI, along with supporting implementation and documentation. The main goal is to allow operators to view the status of, and renew, the SGX wallet authentication certificates directly from the CLI. The changes include new CLI commands, core logic for certificate management, configuration constants, and updates to the documentation.
New SGX Certificate Management Functionality:
CLI Command Additions
SGX commands for Standard and Fair Node:
sgxcommand group to both the standard (skale sgx ...) and Fair Node (fair sgx ...) CLIs, withstatusandrenewsubcommands for managing SGX client certificates.README.mdto document the new SGX commands, their options, and usage examples for both standard and Fair Node CLIs. [1] [2] [3] [4]Core Logic and Configuration
SGX certificate management implementation:
node_cli/core/sgx.pycontaining all logic for checking, renewing, and validating SGX certificates, including secure file handling, backup, and communication with the SGX server.Configuration for SGX support:
node_cli/configs/sgx.pydefining file names, directory paths, timeouts, and other constants used in SGX certificate management.These changes provide a robust, user-facing interface for SGX certificate lifecycle management, improving node operator experience and security.