fix(desktop): preserve browser sign-in recovery guidance

[waleedlatif1]

Summary

• Show actionable sign-in guidance when a browser session expires during Slack authorization, and preserve that recovery reason when returning to desktop.
• Add explicit completion ref types and cover the recovery reason across the callback and Electron/browser handoff.

Type of Change

• Bug fix

Testing

• 83 focused web tests and seven Electron + separate Chromium E2E checks passed. Both sign-in regressions failed before the fix. The E2E writes a JSON report and screenshot for CI artifacts.
• App and desktop type checks, lint, block-registry check, all 52 repository audits, generated-artifact checks, and docs-manifest check passed.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing (new tests pass the test-audit authoring gate)
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 30, 2026 11:10pm UTC

[waleedlatif1]

@greptile

[waleedlatif1]

@cubic-dev-ai review this PR

[cubic-dev-ai]

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

[cubic-dev-ai]

No issues found across 10 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Re-trigger cubic}

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Adds sign-in recovery flow to desktop source connection.

The PR appears safe to merge; no actionable regression was established.

Summary

The PR carries a missing-browser-session reason from the Slack OAuth callback to its completion page and through the browser-to-desktop handoff, where it becomes actionable sign-in guidance. It also updates callback and Electron end-to-end coverage.

Diagram

sequenceDiagram
    participant Browser
    participant Callback as Slack callback
    participant Completion as Slack completion page
    participant Loopback as Desktop loopback
    participant Desktop
    Browser->>Callback: Return from Slack with state
    Callback-->>Completion: "ok=false, reason=signin_required"
    Completion->>Browser: Finish matching source attempt
    Browser->>Loopback: "error=signin_required"
    Loopback-->>Desktop: Connection failure and request ID
    Desktop-->>Desktop: Show browser sign-in guidance

Loading

_{Reviews (1) · Last reviewed commit: "fix(desktop): preserve browser sign-in r..."}