Skip to content

fix(chat): keep empty search activity collapsed - #8477

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/search-empty-activity
Sep 30, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/search-empty-activity

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Only expand live workspace search activity when it has source links.
  • Remove empty “No results” details while preserving source lists and manual disclosure choices.

Type of Change

  • Bug fix

Testing

  • Focused activity and citation tests: 4 files, 9 tests passed (tool-activity-group, agent-group, lane-activity, retrieval-citations).
  • New empty-search regression failed against the pre-fix code and passed after the fix.
  • bun run --cwd apps/sim type-check
  • Cleanup review, bun run lint, block-registry audit, all 52 checks in bun run check:audits, and bun run docs-manifest:check.
  • Regenerated agent stream docs, docs manifest, and skill links; no generated changes.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 30, 2026 9:24pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Refactors search result display logic in chat activity.

The PR appears safe to merge.

Summary

The PR keeps searches without source links from opening live activity details and removes the empty “No results” detail, while retaining source lists and manual disclosure behavior.

  • Adds a regression test for an empty search followed by other tools.

Reviews (1) · Last reviewed commit: "fix(chat): keep empty search activity co..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 594894c into staging Sep 30, 2026
23 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/search-empty-activity branch September 30, 2026 21:29

This branch was previously deployed

1 inactive deployment
Preview — e1e9b340 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant