Skip to content

feat(search): add Lucidchart and Lucidspark live search - #8475

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/lucid-live-search
Sep 30, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/lucid-live-search

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Add Lucidchart and Lucidspark live search through Lucid’s official read-only MCP server, using the existing member-account connection and authorization flow.
  • Support title discovery, document-scoped shape-text search and complete structured graph reads with identity, revision, coverage and size checks. Document the search limits and include Lucid’s official SVG icon.
  • Preserve existing MCP payload handling while recognizing Lucid’s widget metadata envelope. Allow only the four required read tools.

Companion: simstudioai/mothership#556

Type of Change

  • New feature

Testing

  • Real Lucidchart and Lucidspark MCP acceptance: 12 positive/negative query and read checks; outgoing arguments validated against advertised schemas.
  • Real loopback HTTP MCP suite: 31 checks with JSON reports, including multi-page/region preservation, limits, cancellation and access/revision changes. Guard-removal controls and regressions independently proved query admission, candidate isolation, error preservation and complete-read safety.
  • 13 real Postgres setup checks; 1,127 provider/credential/MCP regressions and 10 contract tests.
  • All 26 workspace type checks, 52 audits, lint, applicable generators, registry and docs checks passed. Cleanup and test-audit completed.
  • Live samples cover one page/region per product; larger layouts use synthetic HTTP fixtures. The local Sim browser enrollment and LLM flow remain unverified because of a session-recovery loop; no authentication bypass was used.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 30, 2026 7:56pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Adds Lucid live search integration alongside existing providers.

The PR appears safe to merge; no new actionable issue or outstanding previous finding remains.

Summary

Adds member-account Lucidchart and Lucidspark live search through Lucid’s read-only MCP server.

  • Supports title search, document-scoped shape-text search, and bounded structured reads with identity and revision checks.
  • Adds connection metadata, guidance, documentation, and loopback MCP acceptance checks.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Member's Lucid connection] --> B[Authorized live-search session]
  B --> C{Request}
  C -->|Title or document text| D[Lucid MCP search]
  D --> E[Validate candidate metadata]
  C -->|Read result| F[Fetch page-region graph]
  F --> G[Check coverage, identity, revision and size]
  G --> H[Structured document]
Loading

Reviews (2) · Last reviewed commit: "fix(search): validate Lucid queries and ..."

Comment thread apps/sim/lib/sim-search/live/policy-schema.ts

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 26 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/lib/sim-search/live/lucid-mcp.ts
Comment thread apps/sim/lib/api/contracts/mothership-assistant-tools.ts
@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Comments Outside Diff

These findings could not be posted inline.

  • P1 Lucid scopes reject every result apps/sim/lib/sim-search/live/policy-schema.ts:107 ▶

    When an administrator selects specific Lucid documents or excludes document IDs, search returns no results-even for documents the policy allows. These settings require each candidate to be verified, but the verifier has no Lucid case and rejects them all. Add Lucid document-ID verification so the new Documents scope works.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 28 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit df47953 into staging Sep 30, 2026
24 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/lucid-live-search branch September 30, 2026 20:02
@github-actions github-actions Bot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Sep 30, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Cross-repo companion check

One or more companion PRs aren't merged into staging yet. Merging this without them will leave copilot and sim out of sync — merge them in lockstep.

This branch was previously deployed

1 inactive deployment
Preview — 240a97c1 Deployed Sep 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant