Skip to content

chore(flags): drop leftover references to the retired async projection flag - #8320

Merged
waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-dead-flag-references
Sep 26, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
chore/remove-dead-flag-references

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Rewords the two remaining comments that named the removed knowledge-async-projection flag (the projection-mode setting in packages/db/knowledge-projection.ts and the projector integration suite header); behavior is unchanged
  • Audited the rest of the codebase for the feature flags just retired from AppConfig: their code paths, registry entries, and fallback env vars (.env.example, env.ts, Helm values, self-hosting docs) were already removed by earlier cleanups, so nothing else references them

Type of Change

  • Chore

Testing

Lint, check:audits, and docs-manifest:check

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 26, 2026 7:14am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Removes outdated flag references from comments.

The PR appears safe to merge.

Summary

This PR removes references to a retired feature flag from two comments while preserving their explanation of deferred projection behavior.

  • Updates the projector setting comment to distinguish current writers from earlier releases.
  • Updates the integration suite header to describe its deferred-write scenario without naming the retired flag.

Reviews (1) · Last reviewed commit: "chore(flags): drop leftover references t..."

@waleedlatif1
waleedlatif1 merged commit 2b01631 into staging Sep 26, 2026
23 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/remove-dead-flag-references branch September 26, 2026 07:15

This branch was successfully deployed

1 active deployment
Preview — 646f44e0 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant