feat(search): refine sources, history and result states by waleedlatif1 · Pull Request #8312 · simstudioai/sim

waleedlatif1 · 2026-09-26T00:23:59Z

Summary

Keep Search sources inline and add an explicit View all sources action without replacing the user’s selected panel.
Add private Recently viewed and Recent searches shortcuts with stable spacing, bounded history and a clear action. Store navigation snapshots scoped to the signed-in user and organization; retain current membership and capability checks without requiring an indexed copy or querying each source again. Opening a source still uses the destination’s current access checks.
Acknowledge search submission immediately, delay filters until results arrive, and use shared source/date dropdowns. Keep result excerpts within three lines and show Docs, Sheets, and Slides icons for their document URLs. Use consistent status labels without trailing ellipses.

Type of Change

Feature and bug fix

Testing

1,443 touched/sibling tests across access, search, chat and source rendering in the implementation round; 17 affected source/provider tests passed again for the final history change.
4 real-PostgreSQL history tests covering live and internal links without an index, user/organization isolation, revoked membership, concurrent writes, deduplication, limits, expiry and clearing. The no-index regression failed before the fix.
Fresh-database migration and migration replay passed. The unused document-URL index and its unshipped migration were removed; only the additive history table remains.
All nine cleanup passes, type-check and lint across 26 workspaces, all 51 audits, generated artifacts and docs manifest checks passed.
Local light/dark and narrow-layout QA, keyboard filters, busy submission, bounded snippets and explicit source-panel access.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing (new tests pass the test-audit authoring gate)
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-09-26T00:24:01Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated
docs	Ready	Preview	Sep 26, 2026 2:02am UTC

waleedlatif1 · 2026-09-26T00:24:15Z

@greptile

waleedlatif1 · 2026-09-26T00:24:16Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T00:24:21Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-26T00:27:44Z

Confidence Score: 5/5

[Medium risk] Adds search history tracking and refines search UI states.

The PR appears safe to merge; no new actionable issue or outstanding previous finding was identified.

Summary

The PR refines Search result and source-panel states, adds private recent-search and recently-viewed shortcuts, and changes source history to retain navigation snapshots without requiring an indexed document.

Source visits now save bounded display metadata alongside their URLs.
History reads remain scoped to the signed-in user and organization; source access is checked when a destination is opened.
The unused document-URL index and its unshipped migration are removed.

_{Reviews (5) · Last reviewed commit: "fix(search): keep private history indepe..."}

waleedlatif1 · 2026-09-26T01:10:52Z

@greptile

waleedlatif1 · 2026-09-26T01:10:53Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T01:10:59Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 36 files

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

waleedlatif1 · 2026-09-26T01:45:27Z

@greptile

waleedlatif1 · 2026-09-26T01:45:28Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T01:45:33Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 79 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

waleedlatif1 · 2026-09-26T02:01:13Z

@greptile

waleedlatif1 · 2026-09-26T02:01:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T02:01:19Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 77 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

waleedlatif1 · 2026-09-26T02:06:31Z

@greptile

waleedlatif1 · 2026-09-26T02:06:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-26T02:06:39Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 77 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

improvement(search): keep sources inline and show document icons

458d384

vercel Bot temporarily deployed to Preview September 26, 2026 00:24 Inactive

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

feat(search): add private history and responsive result states

bad9bef

waleedlatif1 changed the title ~~improvement(search): keep sources inline and show document icons~~ feat(search): refine sources, history and result states Sep 26, 2026

vercel Bot deployed to Preview September 26, 2026 01:13 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/app/o/[organizationId]/providers/organization-provider.tsx

Comment thread .../sim/app/workspace/[workspaceId]/home/components/knowledge-search-results/search-filters.tsx Outdated

Comment thread apps/sim/lib/knowledge/search/history/limits.ts Outdated

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/app/o/[organizationId]/search/search.tsx Outdated

fix(search): revalidate recent sources and polish state transitions

aa7dac5

waleedlatif1 mentioned this pull request Sep 26, 2026

v0.9.2: resource dropdown in org view, new library posts, removed unnecessary tests #8303

Merged

vercel Bot deployed to Preview September 26, 2026 01:47 View deployment

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/search/history/repository.ts Outdated

fix(search): keep private history independent of indexed search

b8c8ca1

vercel Bot deployed to Preview September 26, 2026 02:02 View deployment

greptile-apps Bot reviewed Sep 26, 2026

View reviewed changes

Comment thread apps/sim/lib/knowledge/application/search-history.ts

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

waleedlatif1 merged commit 57e5622 into staging Sep 26, 2026
26 of 27 checks passed

waleedlatif1 deleted the codex/search-sources-inline branch September 26, 2026 02:06

cubic-dev-ai Bot reviewed Sep 26, 2026

View reviewed changes

Conversation

waleedlatif1 commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

waleedlatif1 commented Sep 26, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 26, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

This branch was successfully deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

waleedlatif1 commented Sep 26, 2026 •

edited

Loading

vercel Bot commented Sep 26, 2026 •

edited

Loading

greptile-apps Bot commented Sep 26, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading