Skip to content

fix(trigger): exclude integration test files from task discovery - #8307

Merged
waleedlatif1 merged 2 commits into
stagingfrom
fix/trigger-deploy-import
Sep 25, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
fix/trigger-deploy-import

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Trigger.dev imports every file under background/ as a task file and only skips *.test.* / *.spec.* by default
  • chore(tests): remove low-signal tests and consolidate the testing setup #8295 moved two suites to *.integration.ts in background/, so they got bundled as tasks and their top-level vi.mock() threw during indexing, failing every Trigger.dev deploy since
  • Set ignorePatterns in trigger.config.ts to exclude *.integration.* alongside the restated *.test.* / *.spec.* defaults (setting it replaces the CLI defaults)

Type of Change

  • Bug fix

Testing

  • trigger.dev deploy --dry-run before: "Failed to import some task files"; importing each built entry reproduced the vi.mock() error from exactly the two integration files
  • After: no warning, no test files in the bundle, every task entry imports cleanly
  • bun run lint, check:audits (49 audits), docs-manifest:check pass

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 25, 2026 7:10pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes task discovery filter in the build configuration.

The PR appears safe to merge.

Summary

The PR excludes test and integration files from Trigger.dev task discovery, preventing those suites from being imported during deployment. Since the previous review, it also adds .tsx and .jsx to the excluded extensions.

Reviews (2) · Last reviewed commit: "fix(trigger): cover tsx and jsx test fil..."

Comment thread apps/sim/trigger.config.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4ead961 into staging Sep 25, 2026
32 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/trigger-deploy-import branch September 25, 2026 19:55

This branch was previously deployed

1 inactive deployment
Preview — 98d39d58 Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant