fix(trigger): exclude integration test files from task discovery - #8307
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
background/as a task file and only skips*.test.*/*.spec.*by default*.integration.tsinbackground/, so they got bundled as tasks and their top-levelvi.mock()threw during indexing, failing every Trigger.dev deploy sinceignorePatternsintrigger.config.tsto exclude*.integration.*alongside the restated*.test.*/*.spec.*defaults (setting it replaces the CLI defaults)Type of Change
Testing
trigger.dev deploy --dry-runbefore: "Failed to import some task files"; importing each built entry reproduced thevi.mock()error from exactly the two integration filesbun run lint,check:audits(49 audits),docs-manifest:checkpassChecklist
test-auditauthoring gate)