You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Search Assistant can resolve people/resource IDs and read structured details through 39 existing read-only integration operations. The AppConfig flag mothership-search-integration-tools controls gateway discovery, calls, and the corresponding worker prompt instructions. It defaults off and has no environment-variable fallback.
When disabled, new Search requests omit the integration capability; discovery and execution also recheck the flag so an existing conversation cannot keep using it after the updated configuration is observed. The flag uses the shared AppConfig polling/cache behavior, including last-known-good values during AppConfig outages; it is a rollout toggle, while credential and authorization checks remain independent. Build and Plan retain their current integration tools. When enabled, Search uses the person's existing connected account and credential/visibility rules. Native results return normally; no OAuth scopes or additional Search result filtering are introduced. Writes and arbitrary MCP calls remain unavailable.
Sources: Slack, Gmail, Calendar, Drive, Sheets, Jira, Confluence, GitHub, GitLab, and Coda. GitLab personal-token operations retain the existing workspace-only restriction. Gmail labels and GitHub review threads are exposed through their existing shared tool catalogs. Generated-doc discovery now handles inherited version-mapped lists with appended operations.
Type of Change
Bug fix
New feature
Breaking change
Documentation
Other
Testing
492 focused and CI-regression tests passed after rebasing onto dev; includes on/off/on capability changes, revoked discovery/calls, and unchanged Build/Plan behavior.
New flag regressions failed before the guards were implemented, then passed.
Preserved dev's existing test-runner configuration; removing the inherited global mock-clearing override fixed the eight CI failures in older dev suites.
Sim typecheck, all 49 repository audits (including generated docs), lint, and diff checks passed.
Existing durable worker coverage verifies both catalog-free Search prompts and native integration call/checkpoint handling.
Live provider accounts have not been exercised; this rollout enables that testing in dev.
The PR makes selected read-only integration lookups available to Search Assistant behind an AppConfig-only flag, with separate payload, discovery, and execution checks. It also updates shared tool exposure and generated integration documentation.
Search sends the integration capability only while the flag is enabled; Build and Plan keep their existing catalog behavior.
Discovery and execution apply the Search allowlist and connected-account restrictions, but their flag checks can retain an enabled AppConfig value after revocation during refresh failures.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Search request] --> B{AppConfig flag}
B -->|enabled| C[Integration capability in payload]
B -->|disabled| D[No integration capability]
C --> E[Catalog discovery checks flag]
E --> F[Allowed read-only operation]
F --> G[Executor checks flag]
G --> H[Connected-account tool call]
@greptile-apps please re-review the latest head d8a7eeb. Search integration capability is now gated by an AppConfig-only flag, with runtime discovery/execution revocation and regression coverage. The PR now targets dev; prior resolved findings and credential-scope limitations are documented in the description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Search Assistant can resolve people/resource IDs and read structured details through 39 existing read-only integration operations. The AppConfig flag
mothership-search-integration-toolscontrols gateway discovery, calls, and the corresponding worker prompt instructions. It defaults off and has no environment-variable fallback.When disabled, new Search requests omit the integration capability; discovery and execution also recheck the flag so an existing conversation cannot keep using it after the updated configuration is observed. The flag uses the shared AppConfig polling/cache behavior, including last-known-good values during AppConfig outages; it is a rollout toggle, while credential and authorization checks remain independent. Build and Plan retain their current integration tools. When enabled, Search uses the person's existing connected account and credential/visibility rules. Native results return normally; no OAuth scopes or additional Search result filtering are introduced. Writes and arbitrary MCP calls remain unavailable.
Sources: Slack, Gmail, Calendar, Drive, Sheets, Jira, Confluence, GitHub, GitLab, and Coda. GitLab personal-token operations retain the existing workspace-only restriction. Gmail labels and GitHub review threads are exposed through their existing shared tool catalogs. Generated-doc discovery now handles inherited version-mapped lists with appended operations.
Type of Change
Testing
Checklist
Companion PR
Companion: https://github.com/simstudioai/mothership/pull/530