fix(knowledge): deflake projection integration tests by ranking vector assertions exactly - #8289
Merged
Merged
Conversation
…r assertions exactly
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
knowledge-projectionandunfilled-projection-sourceintegration tests intermittently got[]from the vector leg for chunks the access predicate admitspermitted: { kind: 'unbounded', broad: true }, which walks the shared HNSW graph. The files sharing the CI database fill it with degenerate vectors ([1, 0, …], constant rows), so a fixture chunk can be pruned from every neighbour list and becomes unreachable however far the iterative scan goes. The one-hot fixture vector from fix(cli): strip endpoint trailing slashes in linear time, deflake projection test #8285 avoided ties, but not thisbroad: false. With no per-source index, this ranks the sliced sources exactly, under the same on-row visibility predicate the walk applies, so what the tests assert (revoke/grant/unfilled visibility) no longer depends on ANN recallType of Change
Testing
[1, 0, …]rows, an iterative walk with a 100k tuple cap returned 3 of 5 rows sitting at distance 0bun run lint,check:audits,docs-manifest:checkpassChecklist