fix(slack): simplify app creation and setup order by TheodoreSpeaks · Pull Request #8280 · simstudioai/sim

TheodoreSpeaks · 2026-09-24T23:38:38Z

Summary

Open Slack app creation with the manifest already filled in, using the same link format as Sim Search. Send compact JSON to avoid the large spacing gaps in Slack's editor.
Show only the creation action for new apps. Keep manifest copying and an optional preview for existing-app updates.
Validate new bot names before continuing: at most 35 characters, using letters, numbers, spaces, periods, hyphens, or underscores. Preserve reconnect behavior and the legacy default name.
Validate the complete encoded creation link against the shared 30,000-character limit before proceeding; oversized command configurations show an error with instructions to shorten or remove commands.
Order setup as create/update app → install and paste Bot Token → enter remaining credentials → connect. Preserve Back navigation and existing credentials on reconnect.

Type of Change

Bug fix

Testing

Six focused Vitest tests passed across four files. Retained the provider URL encoding contract and demonstrated clipboard retry/default-name regressions failing when their guards are removed; pruned incidental UI assertions.
Browser checks on the running app confirmed invalid/overlong names block Next, valid names progress, compact manifest payloads, and removal of Copy manifest, View manifest, and the new-app Request URL instruction.
Opened the generated link in Slack: corrected name and compact JSON show no manifest validation errors. No app was created and no credentials were saved.
Browser regression checks reproduced an oversized Unicode manifest before the fix and verified recovery after shortening, acceptance at 30,000 characters, and rejection at 30,001.
Workspace type-check, repository lint/lint:check, all 49 CI audits including API validation, block-registry and docs-manifest checks passed.
All nine cleanup passes and git diff --check passed.

Release

Base and intended deployment target: staging. Merging triggers the staging image promotion and CodePipeline. No merge, auto-merge, or production deployment is authorized.

vercel · 2026-09-24T23:38:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 25, 2026 6:52pm UTC

cubic-dev-ai

All reported issues were addressed across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

greptile-apps · 2026-09-24T23:42:39Z

Confidence Score: 5/5

[Medium risk] Refactors Slack app setup flow and manifest handling.

The PR appears safe to merge based on the reviewed changes.

Summary

This PR opens new Slack app creation with a compact, prefilled manifest and reorders setup to collect the Bot Token before remaining credentials. The latest changes add a shared creation-link limit and prevent oversized custom-bot configurations from advancing.

_{Reviews (4) · Last reviewed commit: "fix(slack): reject oversized app creatio..."}

TheodoreSpeaks · 2026-09-25T01:57:19Z

@greptile

TheodoreSpeaks · 2026-09-25T01:57:20Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T01:57:25Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

TheodoreSpeaks · 2026-09-25T18:08:36Z

@greptile

TheodoreSpeaks · 2026-09-25T18:08:37Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T18:08:44Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

1 issue found across 8 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sim/app/workspace/[workspaceId]/integrations/components/connect-slack-bot-modal/connect-slack-bot-modal.tsx">

<violation number="1" location="apps/sim/app/workspace/[workspaceId]/integrations/components/connect-slack-bot-modal/connect-slack-bot-modal.tsx:533">
P2: This direct creation link can exceed the repository’s 30,000-character Slack URL limit by several times when users configure multiple long slash commands, so Slack may not load the manifest and the new-app flow becomes unusable. Enforce an aggregate manifest/URL limit before enabling this action, or provide a bounded fallback for oversized manifests.</violation>
</file>

TheodoreSpeaks · 2026-09-25T18:53:15Z

@greptile

TheodoreSpeaks · 2026-09-25T18:53:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-25T18:53:24Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 9 files

_{Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic}

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread .../components/editor/components/sub-block/components/slack-setup-wizard/slack-setup-wizard.tsx Outdated

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview September 25, 2026 01:56 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

waleedlatif1 mentioned this pull request Sep 25, 2026

v0.9.0: mothership v1, live search, slack list and canvas tools, ui consolidation #8273

Merged

TheodoreSpeaks added 3 commits September 25, 2026 10:49

fix(slack): make manifest copying direct and order setup steps

fa046d7

fix(slack): preserve manual setup and accessible credential fields

6f30261

fix(slack): prefill app creation and validate bot names

95f7565

TheodoreSpeaks force-pushed the codex/improve-slack-setup-wizard branch from f9c56c4 to 95f7565 Compare September 25, 2026 18:07

vercel Bot temporarily deployed to Preview September 25, 2026 18:07 Inactive

TheodoreSpeaks changed the title ~~fix(slack): improve manifest copying and setup order~~ fix(slack): simplify app creation and setup order Sep 25, 2026

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread ...ce/[workspaceId]/integrations/components/connect-slack-bot-modal/connect-slack-bot-modal.tsx Outdated

greptile-apps Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread ...ce/[workspaceId]/integrations/components/connect-slack-bot-modal/connect-slack-bot-modal.tsx Outdated

fix(slack): reject oversized app creation links

b57a91d

vercel Bot temporarily deployed to Preview September 25, 2026 18:52 Inactive

cubic-dev-ai Bot reviewed Sep 25, 2026

View reviewed changes

Comment thread apps/sim/lib/integrations/slack-manifest.ts

TheodoreSpeaks merged commit 0bde1e4 into staging Sep 25, 2026
32 of 33 checks passed

TheodoreSpeaks deleted the codex/improve-slack-setup-wizard branch September 25, 2026 19:50

waleedlatif1 mentioned this pull request Sep 25, 2026

v0.9.2: resource dropdown in org view, new library posts, removed unnecessary tests #8303

Merged

Conversation

TheodoreSpeaks commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Release

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

TheodoreSpeaks commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 25, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

TheodoreSpeaks commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading