Skip to content

refactor(emcn): share product page heading recipe - #8253

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/emcn-next-product-headings
Sep 25, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/emcn-next-product-headings

Conversation

@BillLeoutsakosvl346

@BillLeoutsakosvl346 BillLeoutsakosvl346 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Share the repeated centered product heading typography through an EMCN recipe, then migrate organization Home, organization Search, workspace Home, and the workspace error shell. Preserve each heading's semantic element, text, width, and spacing.

Base and validation

Targets live staging at 1fa912f71f (rebased without changing the patch). The app type check with this branch's own dependencies, EMCN type check, 68 organization Home tests, Biome, and diff whitespace check passed. The two LogsError tests also pass after the follow-up mock update. Independent source review found no blockers.

Source-derived captures using the product CSS and Season font show identical computed styles and RGB pixels for all four headings in light/dark at 16px/20px root size and 540px/1220px viewport widths. Evidence is stored outside the product checkout.

The local design diff check (3.10.7) against the exact staging base 1fa912f71f and product head 7da8f94a45 completed with zero new findings and no coverage failures. The follow-up commit d1a43b5562 changes only logs/error.test.tsx; no product styling changed. A comparable full scan is coordinated outside this PR. Keep this PR unmerged until both bot reviews, required checks, and all review threads are complete.

@vercel

vercel Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 7:27pm UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile review this PR

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge from this review; no actionable issue remains.

Summary

The PR extracts shared heading typography into an EMCN class recipe and applies it to organization Home and Search, workspace Home, and the workspace error shell. The follow-up change adds the export to the logs error test mock.

Reviews (2) · Last reviewed commit: "test: include shared heading export in l..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile review this PR

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author

Visual review: shared product page heading

What changed: Four product headings now use one EMCN typography recipe. Each page keeps its existing h1/h2 semantics, text, width, and local margins. The recipe is the same 26px mobile / 28px sm type, line height, tracking, font, and token colour that these pages already used.

// Before — organization Home opening tag
<h1 className='mb-7 max-w-chat text-balance font-season text-[26px] text-[var(--text-primary)] leading-[1.15] tracking-[-0.01em] sm:text-[28px]'>

// After — same heading content follows
<h1 className={cn(pageHeadingClassName, 'mb-7 max-w-chat')}>

What to inspect: Heading size, wrapping, line height, ink, and surrounding spacing at narrow and wide widths. These are labeled isolated fixtures built from the original staging 316fea02ec heading classes and the current recipe with actual product CSS and Season font. They are not authenticated organization/workspace page captures. The styling patch was rebased unchanged onto staging 1fa912f71f; current PR head is d1a43b556203. All eight before/after screenshot pairs—each showing four headings—across light/dark, 16px/20px root size, and 540px/1220px widths matched in pixels and computed geometry. Four representative pairs:

Viewport / theme / root text Before After
540px / light / 16px Before heading, 540px light 16px After heading, 540px light 16px
540px / dark / 20px Before heading, 540px dark 20px After heading, 540px dark 20px
1220px / dark / 16px Before heading, 1220px dark 16px After heading, 1220px dark 16px
1220px / light / 20px Before heading, 1220px light 20px After heading, 1220px light 20px

@waleedlatif1
waleedlatif1 merged commit 63853e3 into staging Sep 25, 2026
40 of 41 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/emcn-next-product-headings branch September 25, 2026 00:12

This branch was previously deployed

1 inactive deployment
Preview — d1a43b55 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants