You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Share the repeated centered product heading typography through an EMCN recipe, then migrate organization Home, organization Search, workspace Home, and the workspace error shell. Preserve each heading's semantic element, text, width, and spacing.
Base and validation
Targets live staging at 1fa912f71f (rebased without changing the patch). The app type check with this branch's own dependencies, EMCN type check, 68 organization Home tests, Biome, and diff whitespace check passed. The two LogsError tests also pass after the follow-up mock update. Independent source review found no blockers.
Source-derived captures using the product CSS and Season font show identical computed styles and RGB pixels for all four headings in light/dark at 16px/20px root size and 540px/1220px viewport widths. Evidence is stored outside the product checkout.
The local design diff check (3.10.7) against the exact staging base 1fa912f71f and product head 7da8f94a45 completed with zero new findings and no coverage failures. The follow-up commit d1a43b5562 changes only logs/error.test.tsx; no product styling changed. A comparable full scan is coordinated outside this PR. Keep this PR unmerged until both bot reviews, required checks, and all review threads are complete.
The PR appears safe to merge from this review; no actionable issue remains.
Summary
The PR extracts shared heading typography into an EMCN class recipe and applies it to organization Home and Search, workspace Home, and the workspace error shell. The follow-up change adds the export to the logs error test mock.
What changed: Four product headings now use one EMCN typography recipe. Each page keeps its existing h1/h2 semantics, text, width, and local margins. The recipe is the same 26px mobile / 28px sm type, line height, tracking, font, and token colour that these pages already used.
// Before — organization Home opening tag<h1className='mb-7 max-w-chat text-balance font-season text-[26px] text-[var(--text-primary)] leading-[1.15] tracking-[-0.01em] sm:text-[28px]'>
// After — same heading content follows
<h1className={cn(pageHeadingClassName,'mb-7 max-w-chat')}>
What to inspect: Heading size, wrapping, line height, ink, and surrounding spacing at narrow and wide widths. These are labeled isolated fixtures built from the original staging 316fea02ec heading classes and the current recipe with actual product CSS and Season font. They are not authenticated organization/workspace page captures. The styling patch was rebased unchanged onto staging 1fa912f71f; current PR head is d1a43b556203. All eight before/after screenshot pairs—each showing four headings—across light/dark, 16px/20px root size, and 540px/1220px widths matched in pixels and computed geometry. Four representative pairs:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Share the repeated centered product heading typography through an EMCN recipe, then migrate organization Home, organization Search, workspace Home, and the workspace error shell. Preserve each heading's semantic element, text, width, and spacing.
Base and validation
Targets live staging at
1fa912f71f(rebased without changing the patch). The app type check with this branch's own dependencies, EMCN type check, 68 organization Home tests, Biome, and diff whitespace check passed. The two LogsError tests also pass after the follow-up mock update. Independent source review found no blockers.Source-derived captures using the product CSS and Season font show identical computed styles and RGB pixels for all four headings in light/dark at 16px/20px root size and 540px/1220px viewport widths. Evidence is stored outside the product checkout.
The local design diff check (3.10.7) against the exact staging base
1fa912f71fand product head7da8f94a45completed with zero new findings and no coverage failures. The follow-up commitd1a43b5562changes onlylogs/error.test.tsx; no product styling changed. A comparable full scan is coordinated outside this PR. Keep this PR unmerged until both bot reviews, required checks, and all review threads are complete.