Share mirrored workflow field editing treatment by BillLeoutsakosvl346 · Pull Request #8248 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T19:09:35Z

Summary

Share the existing highlighted-text mirror and native caret alignment between workflow short inputs, long inputs, and the repeated field editors.
Keep the input and textarea geometry in a feature-owned MirroredInput / MirroredTextarea treatment.
Preserve controlled value, selection, and scroll synchronization. During IME composition, show native text immediately so the composition remains legible.

Base and verification

Base: #8086 (de7d26f84f). Product change plus focused reviewer fixes on that head.

19 focused workflow tests pass; the mirrored-field test was rerun after reviewer changes (3 pass). Final-head app TypeScript and changed-file Biome checks pass.
32 matched before/after visual pairs cover light/dark, 16px/20px root text, short/long fields, and idle/focus/scroll/composition. Idle/focus/scroll pairs are pixel identical. Composition intentionally changes native text visibility.
The local design diff checker 3.10.7 reported nine component-chrome warnings on the preceding head. The latest source cleanup moves fixed overlay styling into classes; its exact-head diff is queued. The specialized mirrored-editor warnings remain visible for design review.
Full base/head scanner comparison is being completed outside the product PR.

Screenshots, computed styles, and checker reports are held in the external design review directory, not this product branch. No scanner, lint rules, or review artifacts are changed here.

vercel · 2026-09-24T19:09:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 7:35pm UTC

BillLeoutsakosvl346 · 2026-09-24T19:09:48Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:09:52Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:09:56Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T19:16:19Z

Confidence Score: 5/5

The PR appears safe to merge based on the reviewed changes.

Summary

The PR consolidates formatted-text mirrors for workflow inputs and textareas, then moves remaining static mirror styles from inline declarations to Tailwind classes.

The latest changes preserve the reviewed field geometry and scroll treatment.
No new actionable issue was established.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  E[Workflow field editors] --> M[MirroredInput / MirroredTextarea]
  M --> N[Native editing control]
  M --> O[Formatted overlay]
  N -->|scroll and value synchronization| O

_{Reviews (4) · Last reviewed commit: "style(workflow): express mirrored overla..."}

BillLeoutsakosvl346 · 2026-09-24T19:17:27Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:17:31Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:17:36Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T19:25:39Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:25:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:25:48Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T19:35:49Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T19:35:54Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:35:59Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 13 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

* fix(emcn): preserve editable combobox overlay text visibility * Share mirrored workflow field editing treatment (#8248) * refactor(workflow): share mirrored input and textarea editing * test(workflow): use absolute mirrored field import * refactor(workflow): declare mirrored props and class states * style(workflow): express mirrored overlay constants as classes --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

refactor(workflow): share mirrored input and textarea editing

ae0eca2

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...nel/components/editor/components/sub-block/components/mirrored-field/mirrored-field.test.tsx Outdated

test(workflow): use absolute mirrored field import

70801ca

vercel Bot temporarily deployed to Preview September 24, 2026 19:17 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...ts/panel/components/editor/components/sub-block/components/mirrored-field/mirrored-field.tsx Outdated

Comment thread ...ts/panel/components/editor/components/sub-block/components/mirrored-field/mirrored-field.tsx Outdated

refactor(workflow): declare mirrored props and class states

07dcb3e

vercel Bot temporarily deployed to Preview September 24, 2026 19:25 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread .../components/panel/components/editor/components/sub-block/components/starter/input-format.tsx Outdated

style(workflow): express mirrored overlay constants as classes

926d13a

vercel Bot temporarily deployed to Preview September 24, 2026 19:35 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit dc30a6e into codex/control-fix-remaining-workflow-pickers Sep 24, 2026
5 checks passed

waleedlatif1 deleted the codex/emcn-next-mirrored-fields branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Base and verification

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BillLeoutsakosvl346 commented Sep 24, 2026 •

edited

Loading

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading