refactor(emcn): share invalid OTP slot treatment by BillLeoutsakosvl346 · Pull Request #8246 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-24T18:58:48Z

Summary

Add an invalid state to EMCN InputOTPSlot and use it in the three matching account, chat, and public-file OTP flows. The shared slot owns the existing error border, and the underlying input now exposes aria-invalid.

Base and validation

Targets the live account-headings head 5d7f002 (#8074). Focused EMCN tests, EMCN and app type checks, Biome, and diff whitespace checks passed. Independent source review confirmed that invalid border precedence preserves the active ring and that all three consumers forward the same state.

Eight matched visual pairs cover idle and focused OTP slots in light/dark at 16px and 20px root text; before/after pixels and computed styles match. The added ARIA state is intentional. Evidence is stored outside the product checkout.

The local design diff check and comparable full scans are queued. Keep this PR unmerged until those results, both bot reviews, all required checks, and all review threads are complete.

vercel · 2026-09-24T18:58:54Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 7:28pm UTC

BillLeoutsakosvl346 · 2026-09-24T18:58:56Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T18:58:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T18:59:02Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

greptile-apps · 2026-09-24T19:02:06Z

Confidence Score: 5/5

The reviewed changes appear safe to merge; no new actionable issue or outstanding previous finding remains.

Summary

This PR moves invalid OTP slot styling into the shared EMCN component and passes verification-specific invalid state through the account, chat, and public-file flows.

Adds focused tests for slot styling and for distinguishing verification failures from resend failures.
Removes a redundant test-local logger mock.

_{Reviews (5) · Last reviewed commit: "test(ui): use shared logger mock in OTP ..."}

BillLeoutsakosvl346 · 2026-09-24T19:21:04Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T19:21:10Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:21:18Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

BillLeoutsakosvl346 · 2026-09-24T19:23:04Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T19:23:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:23:21Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

BillLeoutsakosvl346 · 2026-09-24T19:24:15Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T19:24:24Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:24:29Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T19:29:00Z

@greptile

BillLeoutsakosvl346 · 2026-09-24T19:29:04Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T19:29:10Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

* improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share larger chip and field geometry * improvement(ui): share public authentication headings * improvement(ui): share workflow panel tab buttons (#8072) * improvement(ui): share workflow panel tab buttons * improvement(ui): reuse chips for panel selection actions (#8166) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share account headings and auth control sizing (#8074) * improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share missing resource states (#8078) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse avatars for owners and members (#8079) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): adopt exact shared 18px typography token * fix(ui): preserve panel and auth control semantics --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com>

* improvement(emcn): share ordinary action geometry in Button * improvement(emcn): consolidate selection controls and styling options * test(emcn): read email geometry from the public export * improvement(emcn): share larger chip and field geometry (#8151) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): use EMCN fields in deployment and setup modals (#8009) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): share knowledge filter headings (#8073) * improvement(ui): share knowledge filter headings * improvement(ui): share inline filter and pagination actions (#8163) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): use chip fields in workflow search and replace (#8076) * improvement(emcn): share larger chip and field geometry * improvement(ui): use chip fields in workflow search and replace * fix(ui): use shared centered chip content on chat errors * improvement(ui): use chips for ordinary product actions (#8081) * improvement(ui): use chips for ordinary product actions * improvement(ui): use shared chip alignment * improvement(ui): use shared search action sizes (#8160) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse chips for custom block upload actions (#8084) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use native attachment action (#8265) * fix(chat): use native attachment action * fix(chat): retain disabled attachment tooltip --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(chat): use EMCN icon button target for attachments * refactor(ui): centralize destructive ghost button colors in EMCN (#7988) * improvement(emcn): share larger chip and field geometry * refactor(ui): use EMCN fields in deployment and setup modals * refactor(ui): centralize destructive ghost button colors in EMCN * improvement(ui): use standard knowledge tag icon size * refactor(ui): consolidate product corner radii * improvement(ui): reuse chip for PII configuration action (#8173) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share collapsible workflow field cards (#8017) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): compose horizontal and credential fields in EMCN (#8164) * improvement(ui): compose horizontal and credential fields in EMCN * Share deploy chat field error treatment (#8255) * refactor(ui): share deploy chat field error treatment * refactor(ui): name deploy error props --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share public headings and product typography (#8069) * improvement(emcn): share larger chip and field geometry * improvement(ui): share public authentication headings * improvement(ui): share workflow panel tab buttons (#8072) * improvement(ui): share workflow panel tab buttons * improvement(ui): reuse chips for panel selection actions (#8166) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): share account headings and auth control sizing (#8074) * improvement(ui): share account status headings * improvement(ui): use shared sizing for auth controls * refactor(emcn): share invalid OTP slot treatment (#8246) * Add shared invalid state to EMCN OTP slots * fix(ui): distinguish OTP verification from resend errors * test(ui): type OTP input queries as inputs * test(ui): import OTP test button prop type * test(ui): use shared logger mock in OTP regression --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): share missing resource states (#8078) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * improvement(ui): reuse avatars for owners and members (#8079) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): adopt exact shared 18px typography token * fix(ui): preserve panel and auth control semantics --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * fix(ui): preserve shared tag actions and product styling fallbacks * fix(ui): keep logs filters on canonical chip height --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>

Add shared invalid state to EMCN OTP slots

112a8b4

vercel Bot deployed to Preview September 24, 2026 19:00 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/(interfaces)/chat/components/auth/email/email-auth.tsx Outdated

fix(ui): distinguish OTP verification from resend errors

36e09d2

vercel Bot temporarily deployed to Preview September 24, 2026 19:20 Inactive

test(ui): type OTP input queries as inputs

0e2136a

vercel Bot temporarily deployed to Preview September 24, 2026 19:23 Inactive

test(ui): import OTP test button prop type

789f87e

vercel Bot temporarily deployed to Preview September 24, 2026 19:24 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/(auth)/verify/otp-error-source.test.tsx Outdated

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/(auth)/verify/otp-error-source.test.tsx Outdated

test(ui): use shared logger mock in OTP regression

1606fa9

vercel Bot temporarily deployed to Preview September 24, 2026 19:28 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit d7f8b69 into codex/control-fix-account-status-headings Sep 24, 2026
8 checks passed

waleedlatif1 deleted the codex/emcn-next-otp-invalid branch September 24, 2026 23:57

Conversation

BillLeoutsakosvl346 commented Sep 24, 2026

Summary

Base and validation

Uh oh!

vercel Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercel Bot commented Sep 24, 2026 •

edited

Loading

greptile-apps Bot commented Sep 24, 2026 •

edited

Loading