fix(preview): scope cursor styling per instance - #8245
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
@greptile review this PR |
|
@cubic-dev-ai review this PR |
@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete. |
Cursor behavior review (corrected)I removed the earlier before/after image table. It showed an isolated mock of two previews, but a static screenshot cannot show a CSS cursor. The images looked the same and did not help review this PR. What changes: Representative source excerpts: Before — generated inside each preview: .preview-mode .react-flow__pane { cursor: ${cursorStyle} !important; }After — each preview supplies its own value: '--preview-cursor': cursorStyle,.preview-mode .react-flow__pane,
.preview-mode .react-flow__selectionpane {
cursor: var(--preview-cursor) !important;
}Behavior check: With Preview A set to
The PR also adds |
Summary
Scope workflow preview cursor styling to each mounted preview instance. Two previews with different pointer/grab settings no longer override each other through document-wide
.preview-moderules. Interactive-node pointer and pressed grab behavior remain.Base and validation
Targets live staging at
316fea02ec. The local design diff check against that base completes with zero new findings. A focused two-instance test, app type check, Biome, and diff whitespace check pass.Matched source-derived before/after captures cover light/dark at 16px and 20px root text, with node hover and pressed states. The old cross-instance cursor leak is visible in the baseline; the new instance cursors differ correctly, with zero non-cursor pixel differences. Evidence is stored outside the product checkout. Independent source review confirmed selector isolation and no global cleanup path.
Comparable full scans and both bot reviews are pending. Keep this PR unmerged until all required checks and review threads are complete.
Visual comparison
Representative matched captures from the local source-derived fixture. Before uses this PR’s base; after uses this PR’s head. Full light/dark and root-size matrices are retained outside the product branch.
Light · 16px root text · default
Dark · 20px root text · default