Skip to content

improvement(search): polish organization search and source results - #8222

Merged
waleedlatif1 merged 3 commits into
stagingfrom
codex/org-search-ui-polish
Sep 24, 2026
Merged

improvement(search): polish organization search and source results#8222
waleedlatif1 merged 3 commits into
stagingfrom
codex/org-search-ui-polish

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Keep each interim search query and its scrollable matches in the conversation, then reveal final cited sources in the resource panel.
  • Align composer controls, sidebar sizing, header/modal spacing, links and source cards with shared UI components. Use compact source action menus and quiet, accessible loading states.
  • Preserve unsent Home, chat and Search input and uploaded attachments across reloads and navigation, including independent drafts for committed Search queries.

Type of Change

  • Improvement and bug fix

Testing

402 focused regression tests across 21 files in the final audit, including query navigation, attachment restoration, sidebar resizing and search recovery. App type-check, full repository lint, all 49 repository audits, block-registry and generated-artifact checks pass. Browser review covered layout, overflow, keyboard access and draft persistence.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 24, 2026 4:01am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the previously reported Search draft collision is fixed and no new actionable defects remain.

Summary

The PR polishes organization Search and source presentation while adding durable, identity-scoped drafts for Search, Home, chat, and attachments.

  • Preserves independent editable drafts for each committed Search query and a latest-draft alias for queryless navigation.
  • Restores unsent text, contexts, and uploaded attachments across remounts and conversation admission.
  • Refines source cards, search activity, loading announcements, composer controls, and sidebar sizing/peek behavior.
  • Adds focused regression coverage for draft isolation, attachment restoration, search transitions, and sidebar interaction.
Diagram 
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  U[User edits Search input] --> Q{Committed URL query?}
  Q -->|Yes| D[Query-specific persisted draft]
  Q -->|No| L[Latest Search draft alias]
  D --> L
  D --> S[Submit query]
  S --> C[Clear submitted query draft]
  C --> R[Render committed search results]
  L --> N[Restore when Search opens without a query]
Loading

Reviews (3) · Last reviewed commit: "fix(search): tighten draft recovery and ..."

greptile-apps[bot]
greptile-apps Bot reviewed Sep 24, 2026
View reviewed changes
Comment thread apps/sim/stores/mothership-drafts/store.ts
Comment thread apps/sim/app/o/[organizationId]/settings/components/integrations/generic-secret-source.tsx
cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 24, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 55 files

Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic

Comment thread ...orkspace/[workspaceId]/home/components/knowledge-search-results/knowledge-search-results.tsx Outdated
Comment thread apps/sim/stores/sidebar/store.ts Outdated
Comment thread apps/sim/app/o/[organizationId]/home/organization-home.tsx Outdated
Comment thread apps/sim/app/workspace/[workspaceId]/components/workspace-chrome/workspace-chrome.tsx Outdated
Comment thread apps/sim/stores/constants.ts
@waleedlatif1

waleedlatif1 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 24, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 60 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread ...wId]/components/panel/components/copilot/components/user-input/hooks/use-file-attachments.ts Outdated
greptile-apps[bot]
greptile-apps Bot reviewed Sep 24, 2026
View reviewed changes
Comment thread apps/sim/app/o/[organizationId]/search/search.tsx Outdated
@waleedlatif1
waleedlatif1 force-pushed the codex/org-search-ui-polish branch from 819cee7 to ade7544 Compare September 24, 2026 04:01
@waleedlatif1

waleedlatif1 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

waleedlatif1 commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 24, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 66 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 2d0353a into staging Sep 24, 2026
35 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/org-search-ui-polish branch September 24, 2026 04:07

This branch was previously deployed

1 inactive deployment
Preview — ade75445 Deployed Sep 24, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1