Skip to content

refactor(ui): reuse icon button for chat file removal - #8183

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/overrides-chat-file-remove
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/overrides-chat-file-remove

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the existing EMCN 20px icon button treatment for the floating chat attachment remove action in place of its local 16px sizing.
  • Reveal the action on keyboard focus as well as hover. Keep its corner placement, accessible label, remove callback, and propagation handling.

Type of Change

  • Improvement

Testing

  • bun run lint, bun run lint:check, bun run type-check, bun run check:audits (47 audits), bun run docs-manifest:check, and bun run apps/sim/scripts/check-block-registry.ts origin/staging passed.
  • packages/emcn: bun run test (349 tests) passed.
  • Matched light/dark rest, hover, and keyboard focus screenshots plus click and propagation checks in an equivalent fixture using the actual EMCN Button, X icon, product font, and product CSS.
  • Full conformance scan on staging fell from 891 to 889 findings, with the two targeted overrides removed and none added. The committed PR diff linter reported no findings.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Relevant tests pass
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 23, 2026 12:46am UTC

Request Review

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Matched before/after comparisons for the floating chat attachment remove action. Equivalent fixture with actual EMCN Button and X icon, product font and CSS, and synthetic files. The target grows from 16px to 20px; hover reveal and remove behavior remain. Keyboard focus now reveals the control.

Light theme, image hover:
clipboard

Dark theme, image hover:
clipboard

Document hover:
clipboard

Keyboard focus on image removal:
clipboard

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, accessibility, security, or repository-rule violations identified.

Summary

This PR standardizes the chat attachment removal control on the existing EMCN icon-button treatment.

  • Replaces local 16px button sizing with the shared 20px icon size.
  • Reveals the removal action on keyboard focus as well as hover.
  • Preserves the accessible label, removal callback, and click-propagation handling.

Reviews (1) · Last reviewed commit: "refactor(ui): reuse icon button for chat..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit adea171 into staging Sep 23, 2026
40 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-chat-file-remove branch September 23, 2026 00:58

This branch was previously deployed

1 inactive deployment
Preview — ece9f2f8 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants