Skip to content

refactor(ui): use shared icon buttons in card headers - #8181

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-remaining-field-cardsfrom
codex/overrides-collapsible-card-actions
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-remaining-field-cardsfrom
codex/overrides-collapsible-card-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Summary

  • Use the shared 20px EMCN icon button treatment for Add Filter, Delete Filter, and Delete Variable in collapsible card headers.
  • Keep the existing action variants, labels, disabled behavior, and propagation handling. The larger targets shift the two filter actions 12px inward and slightly thin their glyph strokes.

Type of Change

  • Improvement

Testing

  • bun run lint, bun run lint:check, bun run type-check, bun run check:audits (47 audits), bun run docs-manifest:check, and bun run apps/sim/scripts/check-block-registry.ts origin/codex/control-fix-remaining-field-cards passed.
  • packages/emcn: bun run test (385 tests) passed.
  • Matched light/dark, rest/hover/focus/collapsed/narrow screenshots and interaction checks in an equivalent fixture using the actual EMCN components and product CSS. All three actions still fire independently of card collapse; disabled actions stay disabled.
  • Full conformance scan on the actual parent base fell from 806 to 800 findings, with exactly six targeted findings removed and none added. The committed PR diff linter reported no findings.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Relevant tests pass
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 23, 2026 12:28am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, accessibility, security, or repository-rule issues identified.

Summary

This PR standardizes three collapsible-card header actions on the shared EMCN 20px icon-button treatment.

  • Migrates Add Filter and Delete Filter actions to Button size='icon'.
  • Migrates Delete Variable to the same shared treatment.
  • Preserves action variants, accessible labels, disabled behavior, and event propagation handling.

Reviews (1) · Last reviewed commit: "refactor(ui): use shared icon buttons in..."

@BillLeoutsakosvl346

BillLeoutsakosvl346 commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Matched before/after screenshots for the three CollapsibleCard header actions. The comparison uses an equivalent fixture with actual EMCN Button, CollapsibleCard, icons, the product font, and product CSS; card content is synthetic. The 13–14px bare targets become 20px controls. Verified light/dark, hover, keyboard focus, collapsed, narrow title, and read-only states; action clicks still leave the cards expanded.

Light theme, rest state:
clipboard

Dark theme, rest state:
clipboard

Keyboard focus on Add Filter:
clipboard

Narrow viewport and long title:
clipboard

@waleedlatif1
waleedlatif1 merged commit c0b7e9e into codex/control-fix-remaining-field-cards Sep 23, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-collapsible-card-actions branch September 23, 2026 01:15
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
…8022)

* refactor(ui): reuse shared cards for workflow inputs and variables

* refactor(ui): use shared icon buttons in card headers (#8181)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share static API and MCP parameter cards (#8027)

* refactor(ui): share static API and MCP parameter cards

* fix(ui): preserve specialized tiny action geometry

* improvement(ui): reuse collapsible cards for MCP tools (#8170)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was previously deployed

1 inactive deployment
Preview — 8a6530e4 Deployed Sep 23, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants