Skip to content

improvement(ui): reuse inline and overlay workflow actions - #8161

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-workflow-preview-actionsfrom
codex/overrides-workflow-actions
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-workflow-preview-actionsfrom
codex/overrides-workflow-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Generate and version actions now use Button size="inline". Generate retains its 20px height with slightly smaller horizontal padding; version actions use 20px height and shared neutral text colors. Workflow previews compose the existing OverlayActionButton: 24→28px, transparent resting fill with blur and shared theme-aware hover. Positioning, tooltips, labels, refs, disabled states and handlers remain unchanged.

All workspace type checks, lint, import/API validation and the complete EMCN suite pass. All 43 relevant sub-block/deployment tests pass. Browser fixtures use the actual preview wrapper and equivalent small-action JSX with local handlers. Light/dark, keyboard activation, focus, hover, disabled controls and enlarged text were checked. Backend generation/deployment and authenticated navigation were not exercised. The viewport override did not apply during this session; narrow viewport coverage remains incomplete.

Both external linters ran against the actual target: all ten targeted overrides removed (796 → 786 total findings), no added full-scan findings and zero diff-checker violations. No linters or review artifacts are included.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 9:16pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the changes are behavior-preserving design-system consolidations with no actionable regressions identified.

Summary

This PR consolidates workflow UI actions onto existing EMCN component variants while preserving their behavior.

  • Uses the canonical 20px inline Button size for version and Generate actions.
  • Reuses OverlayActionButton for workflow-preview corner actions, increasing them from 24px to 28px and adopting shared overlay styling.
  • Keeps existing labels, tooltips, handlers, refs, disabled states, and positioning intact.

Reviews (1) · Last reviewed commit: "improvement(ui): reuse inline and overla..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after visual checks for 08b4f43. The preview uses the actual wrapper; Generate/version controls reproduce the production JSX with local handlers. Light/dark, hover, keyboard focus/activation, disabled states and enlarged text checked. Generation/deployment services and authenticated workflow navigation were not exercised. The browser viewport override did not apply, so narrow-viewport coverage is incomplete.

Intentional differences: inline actions use shared 20px geometry and neutral text; Generate has slightly less horizontal padding. Preview action grows 24→28px and adopts the existing transparent/blur overlay treatment.

Light — before left, after right:
clipboard

Dark — before left, after right:
clipboard

Small actions, 2× enlarged crop:
clipboard

Preview hover, 3× enlarged crop:
clipboard

@waleedlatif1
waleedlatif1 merged commit 319f8bb into codex/control-fix-workflow-preview-actions Sep 23, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-workflow-actions branch September 23, 2026 02:24

This branch was previously deployed

1 inactive deployment
Preview — 08b4f432 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants