improvement(ui): use regular geometry for browser actions - #8157
Merged
waleedlatif1 merged 1 commit intoSep 23, 2026
Merged
waleedlatif1 merged 1 commit into
waleedlatif1 merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
Contributor
Author
waleedlatif1
merged commit Sep 23, 2026
fe51709
into
codex/control-fix-browser-toolbar-actions
11 checks passed
BillLeoutsakosvl346
added a commit
that referenced
this pull request
Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share browser toolbar actions * refactor(ui): remove redundant browser action client boundary * improvement(ui): use regular geometry for browser actions (#8157) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): preserve browser toolbar button footprint --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




BrowserToolbarButton now uses the shared regular Button geometry instead of local 30px sizing and zero-padding classes. Navigation and utility actions are 28px at default text size; ghost-secondary colors, corners, SVG strokes, shrink behavior, labels, refs, native events and type="button" are retained.
Validation: all workspace types, lint, import/API audits and the complete EMCN suite pass; 120 browser consumer tests pass. Both design linters ran against the actual target and the full scan removes the two targeted overrides with none added. Light/dark, hover, disabled, enlarged-text and 390px comparisons use the actual wrapper with local handlers. An EMCN menu composition verifies ArrowDown opening, Escape closing and focus restoration. No remote browser session or real navigation service was exercised. Before/after screenshots are posted in a separate comment; artifacts and linters are outside the PR.