Skip to content

improvement(ui): use regular geometry for browser actions - #8157

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-browser-toolbar-actionsfrom
codex/overrides-browser-actions
Sep 23, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-browser-toolbar-actionsfrom
codex/overrides-browser-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

BrowserToolbarButton now uses the shared regular Button geometry instead of local 30px sizing and zero-padding classes. Navigation and utility actions are 28px at default text size; ghost-secondary colors, corners, SVG strokes, shrink behavior, labels, refs, native events and type="button" are retained.

Validation: all workspace types, lint, import/API audits and the complete EMCN suite pass; 120 browser consumer tests pass. Both design linters ran against the actual target and the full scan removes the two targeted overrides with none added. Light/dark, hover, disabled, enlarged-text and 390px comparisons use the actual wrapper with local handlers. An EMCN menu composition verifies ArrowDown opening, Escape closing and focus restoration. No remote browser session or real navigation service was exercised. Before/after screenshots are posted in a separate comment; artifacts and linters are outside the PR.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:43pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge; the geometry migration is consistent with the shared Button API and preserves existing toolbar semantics.

Summary

Browser toolbar actions now use the shared regular Button geometry instead of local fixed sizing.

  • Replaces size-[30px] p-0 with iconSize='regular', producing the canonical 28px square action geometry.
  • Preserves shrink behavior, the existing ghost-secondary treatment, small-size typography and corners, caller classes, native button properties, and forwarded refs.

Reviews (1) · Last reviewed commit: "improvement(ui): use regular geometry fo..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before → after at the same viewport. Browser toolbar actions now use the shared 28px geometry (previously 30px); colors, corners, labels, refs and handlers stay unchanged. These captures render the actual wrapper with local handlers. Remote browser navigation was not exercised.

Light:
clipboard

Dark:
clipboard

2× close-up, light:
clipboard

2× close-up, dark hover (each hovered control captured separately):
clipboard

Also checked: 390px viewport, 20px root text, disabled actions, ArrowDown/Escape and menu-trigger focus restoration. These checks do not assert remote-session behavior.

@waleedlatif1
waleedlatif1 merged commit fe51709 into codex/control-fix-browser-toolbar-actions Sep 23, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-browser-actions branch September 23, 2026 02:11
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(ui): share browser toolbar actions

* refactor(ui): remove redundant browser action client boundary

* improvement(ui): use regular geometry for browser actions (#8157)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): preserve browser toolbar button footprint

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

This branch was previously deployed

1 inactive deployment
Preview — 1b5cd15c Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants