Skip to content

improvement(ui): use shared geometry for standard icon actions - #8153

Merged
waleedlatif1 merged 1 commit into
codex/control-fix-field-disclosuresfrom
codex/overrides-icon-actions
Sep 22, 2026
Merged

waleedlatif1 merged 1 commit into
codex/control-fix-field-disclosuresfrom
codex/overrides-icon-actions

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Document/image toolbars, microphone and public-chat actions, and playground buttons now use Button geometry props instead of repeating size, padding and corner classes. Existing event handlers, refs, ARIA state, recording animation and image-resize behavior are preserved.

  • Desktop actions keep their 28px/32px targets; document toolbar and image-resize controls keep their 40px mobile targets.
  • Toolbar and microphone actions use the existing quiet/active neutral treatments. Their hover fill is intentionally shared; formerly fixed 28px actions now scale to 35px with a 20px root font.
  • The document toolbar focus treatment and image handle's bottom/right alignment remain explicit local exceptions.

Validation: all workspace type checks, import/API audits, lint and the complete EMCN suite passed; 76 relevant consumer tests passed. The diff design checker reports no new violations, and the full scan removes 19 styling findings with none added. Light/dark, hover, selected, disabled, keyboard focus, mobile and enlarged-text comparisons use actual components in local fixtures; dragging the actual TipTap image handle produces matching 240×120 images. No microphone recording or backend messaging was exercised. Before/after images are posted in a separate review comment.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Sep 22, 2026 8:18pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 7 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge with no actionable correctness, security, or repository-rule issues identified.

Summary

This PR replaces repeated icon-action sizing, padding, and corner classes with shared Button geometry properties across chat, playground, document editing, and microphone controls.

  • Preserves desktop and responsive touch-target dimensions.
  • Keeps image-resize positioning and pointer behavior local to the image control.
  • Adopts the shared quiet/active treatments for toolbar and microphone actions.
  • Updates focused consumer tests to assert the generated shared geometry.

Reviews (1) · Last reviewed commit: "improvement(ui): use shared geometry for..."

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before (left) / after (right), light and dark. Actual product components with local state; playground actions are equivalent isolated JSX. Desktop 28/32px and mobile 40px targets are preserved. Shared neutral hover is intentional. Table header is unchanged context after its prerequisite fix.

Light before and after
Dark before and after

2× enlarged controls (original pixels):

Controls enlarged 2x

Matched hover state, 2× enlargement:

Matched hover enlarged 2x

Captured from base 2365885c52 and head 65d9681615. The full local gallery also contains keyboard focus, disabled/selected states, 390px mobile, enlarged text and real image drag resizing (both 200×100 → 240×120). No microphone recording or backend messaging was exercised.

@waleedlatif1
waleedlatif1 merged commit 7bf8fe3 into codex/control-fix-field-disclosures Sep 22, 2026
11 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/overrides-icon-actions branch September 22, 2026 21:29
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(ui): share additional-field disclosures

* fix(ui): preserve tiny actions and use shared sidebar geometry

* improvement(ui): use shared geometry for standard icon actions (#8153)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): centralize overlay action buttons in EMCN (#7990)

* refactor(ui): centralize overlay action buttons in EMCN

* improvement(ui): share workflow preview actions (#8065)

* improvement(ui): share workflow preview actions

* improvement(ui): reuse inline and overlay workflow actions

* refactor(emcn): share Code.Viewer appearances (#8238)

* Add shared Code.Viewer appearances for product surfaces

* Test flat virtualized Code.Viewer terminal chrome

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* Share table sidebar shell and scroll body (#8249)

* Share table sidebar shell and scroll body

* test(tables): cover shared sidebar dialog state

* test(tables): preserve sidebar scroll state

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* Keep workflow preview values readable (#8256)

* fix(ui): keep preview values readable and restore version tint

* fix(ui): keep preview file actions inert

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): reuse shared button and focus treatments (#8187)

* improvement(ui): reuse shared button and focus treatments

* fix(emcn): include outline reset in muted focus ring

* fix(ui): make closed table sidebars inert and strengthen focus ring

* Carry code search overlay into the live EMCN stack (#8275)

* refactor(ui): share code search overlay controls

* refactor(emcn): own compact code search field chrome

* test(ui): cover floating compact code search

* refactor(emcn): compose compact search from shared chip surface

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): announce code search result changes

* docs(ui): describe shared table sidebar exports

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Waleed <walif6@gmail.com>

This branch was previously deployed

1 inactive deployment
Preview — 65d96816 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants