improvement(ui): use shared geometry for standard icon actions - #8153
waleedlatif1 merged 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
|
Before (left) / after (right), light and dark. Actual product components with local state; playground actions are equivalent isolated JSX. Desktop 28/32px and mobile 40px targets are preserved. Shared neutral hover is intentional. Table header is unchanged context after its prerequisite fix. 2× enlarged controls (original pixels): Matched hover state, 2× enlargement: Captured from base |
7bf8fe3
into
codex/control-fix-field-disclosures
* improvement(emcn): share ordinary action geometry in Button * improvement(ui): share additional-field disclosures * fix(ui): preserve tiny actions and use shared sidebar geometry * improvement(ui): use shared geometry for standard icon actions (#8153) Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * refactor(ui): centralize overlay action buttons in EMCN (#7990) * refactor(ui): centralize overlay action buttons in EMCN * improvement(ui): share workflow preview actions (#8065) * improvement(ui): share workflow preview actions * improvement(ui): reuse inline and overlay workflow actions * refactor(emcn): share Code.Viewer appearances (#8238) * Add shared Code.Viewer appearances for product surfaces * Test flat virtualized Code.Viewer terminal chrome --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Share table sidebar shell and scroll body (#8249) * Share table sidebar shell and scroll body * test(tables): cover shared sidebar dialog state * test(tables): preserve sidebar scroll state --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * Keep workflow preview values readable (#8256) * fix(ui): keep preview values readable and restore version tint * fix(ui): keep preview file actions inert --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Waleed <walif6@gmail.com> * improvement(ui): reuse shared button and focus treatments (#8187) * improvement(ui): reuse shared button and focus treatments * fix(emcn): include outline reset in muted focus ring * fix(ui): make closed table sidebars inert and strengthen focus ring * Carry code search overlay into the live EMCN stack (#8275) * refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> * fix(ui): announce code search result changes * docs(ui): describe shared table sidebar exports --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local> Co-authored-by: Codex <codex@openai.com> Co-authored-by: Waleed <walif6@gmail.com>




Document/image toolbars, microphone and public-chat actions, and playground buttons now use Button geometry props instead of repeating size, padding and corner classes. Existing event handlers, refs, ARIA state, recording animation and image-resize behavior are preserved.
Validation: all workspace type checks, import/API audits, lint and the complete EMCN suite passed; 76 relevant consumer tests passed. The diff design checker reports no new violations, and the full scan removes 19 styling findings with none added. Light/dark, hover, selected, disabled, keyboard focus, mobile and enlarged-text comparisons use actual components in local fixtures; dragging the actual TipTap image handle produces matching 240×120 images. No microphone recording or backend messaging was exercised. Before/after images are posted in a separate review comment.