refactor(ui): share field disclosures and icon action geometry by BillLeoutsakosvl346 · Pull Request #8038 · simstudioai/sim

BillLeoutsakosvl346 · 2026-09-19T21:27:51Z

Share additional-field disclosure rows and ordinary icon-action geometry through existing EMCN components.

FieldDisclosure composes Button and dashed divider lines; editor/table consumers retain their labels, state, permission guards, chevron animation and keyboard focus treatment.
Table headers, document/image toolbars, microphone/public-chat actions and playground controls use shared sizes. Default desktop 28px/32px and mobile 40px targets are retained. Former fixed 28px controls scale with enlarged text.
Toolbar and microphone controls deliberately adopt existing quiet/active resting colours and hover fills, including a brighter inactive microphone in dark mode. Recording animation and handlers are unchanged. Tiny content-sized chat/editor controls remain unchanged.

Validation: all workspace type/import/API/lint checks, the complete EMCN suite and relevant consumer tests pass. Current-head full CI, including application build and PostgreSQL tests, passes. Browser fixtures use actual components with local state for light/dark, selected/disabled/focus/hover, mobile, enlarged text and image drag resizing. No microphone recording, authenticated workspace or backend messaging run was exercised.

Shared-definition notifications and retained tiny-action overrides remain explicit in the external design audit. Review fixtures, linters and screenshots are outside the product diff.

vercel · 2026-09-19T21:27:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Sep 24, 2026 11:25pm UTC

greptile-apps · 2026-09-19T21:30:24Z

Confidence Score: 5/5

The PR appears safe to merge; no actionable new issue remains, and all previous findings are resolved.

Summary

This PR consolidates repeated UI patterns into shared EMCN and application components while preserving consumer-specific state and behavior.

Adds shared field disclosures, icon-action geometry, focus-ring styling, code-viewer appearances, and overlay actions.
Reuses shared table sidebar shells, headers, scrolling regions, code-search overlays, and workflow-preview actions.
Refines read-only workflow-preview styling so displayed values remain legible while controls stay noninteractive.
Adds focused tests for shared geometry, search controls, sidebar persistence, code appearances, disclosures, and preview behavior.
The latest revision documents both shared table-sidebar exports, resolving the remaining repository-rule finding.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  EMCN[Shared EMCN primitives] --> FD[FieldDisclosure]
  EMCN --> OAB[OverlayActionButton]
  EMCN --> BTN[Button geometry and focus ring]
  EMCN --> CODE[Code.Viewer appearances]
  FD --> Editor[Workflow editor]
  FD --> WSidebar[Workflow sidebar]
  OAB --> Logs[Log and trace viewers]
  OAB --> Preview[Workflow previews]
  BTN --> Toolbars[Chat, toolbar, microphone, and sidebar actions]
  CODE --> Logs
  CODE --> Preview
  CODE --> Terminal[Terminal output]
  Search[CodeSearchOverlay] --> Logs
  Search --> Preview
  Search --> Terminal

_{Reviews (13) · Last reviewed commit: "docs(ui): describe shared table sidebar ..."}

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-19T21:37:17Z

@greptile

BillLeoutsakosvl346 · 2026-09-19T21:37:18Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-19T21:37:23Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 5 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-21T17:57:17Z

Before / after visual comparison

Additional-field disclosure rows share the button/divider implementation. Expanded and collapsed treatments retain their spacing and appearance.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Current PR head checked at posting: 2d56098b9b.

BillLeoutsakosvl346 · 2026-09-22T19:59:02Z

@greptile

BillLeoutsakosvl346 · 2026-09-22T19:59:03Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T19:59:09Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 13 files

_{Tip: instead of fixing issues one by one fix them all with cubic

Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-22T20:14:38Z

@greptile Please re-review the current head; each finding has a response and the applicable fixes are pushed.

BillLeoutsakosvl346 · 2026-09-22T20:14:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-22T20:14:46Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 9 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T22:50:55Z

@greptileai review this PR on the current head (4a3986b)

BillLeoutsakosvl346 · 2026-09-24T22:56:18Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T22:56:19Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T22:56:24Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 55 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T23:00:45Z

@greptile please review the latest commit 084ce5a on this PR

* refactor(ui): share code search overlay controls * refactor(emcn): own compact code search field chrome * test(ui): cover floating compact code search * refactor(emcn): compose compact search from shared chip surface --------- Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

BillLeoutsakosvl346 · 2026-09-24T23:13:52Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T23:13:57Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:14:02Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 58 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Fix all with cubic | Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T23:21:09Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T23:21:13Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:21:18Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 58 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

BillLeoutsakosvl346 · 2026-09-24T23:25:44Z

@greptile review this PR

BillLeoutsakosvl346 · 2026-09-24T23:25:48Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-09-24T23:25:53Z

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 58 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.

Re-trigger cubic}

vercel Bot deployed to Preview September 19, 2026 21:29 View deployment

greptile-apps Bot reviewed Sep 19, 2026

View reviewed changes

Comment thread packages/emcn/src/components/field-divider/field-divider.tsx

cubic-dev-ai Bot reviewed Sep 19, 2026

View reviewed changes

vercel Bot deployed to Preview September 19, 2026 21:38 View deployment

vercel Bot temporarily deployed to Preview September 20, 2026 00:55 Inactive

vercel Bot temporarily deployed to Preview September 21, 2026 03:31 Inactive

improvement(emcn): share ordinary action geometry in Button

d583476

BillLeoutsakosvl346 force-pushed the codex/control-fix-icon-button-sizing branch from 0be585b to 13f85d8 Compare September 22, 2026 19:28

improvement(ui): share additional-field disclosures

f472cbb

BillLeoutsakosvl346 changed the base branch from codex/control-fix-icon-button-sizing to codex/overrides-button-sizing September 22, 2026 19:57

BillLeoutsakosvl346 force-pushed the codex/control-fix-field-disclosures branch from 2d56098 to f472cbb Compare September 22, 2026 19:57

vercel Bot deployed to Preview September 22, 2026 19:59 View deployment

greptile-apps Bot reviewed Sep 22, 2026

View reviewed changes

Comment thread ...pace/[workspaceId]/tables/[tableId]/components/table-sidebar-header/table-sidebar-header.tsx

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

fix(ui): preserve tiny actions and use shared sidebar geometry

2365885

vercel Bot temporarily deployed to Preview September 22, 2026 20:13 Inactive

cubic-dev-ai Bot reviewed Sep 22, 2026

View reviewed changes

fix(ui): make closed table sidebars inert and strengthen focus ring

084ce5a

vercel Bot deployed to Preview September 24, 2026 22:57 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

vercel Bot deployed to Preview September 24, 2026 23:13 View deployment

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread apps/sim/app/workspace/[workspaceId]/components/code-search-overlay/code-search-overlay.tsx

fix(ui): announce code search result changes

cc2699e

vercel Bot temporarily deployed to Preview September 24, 2026 23:20 Inactive

greptile-apps Bot reviewed Sep 24, 2026

View reviewed changes

Comment thread ...pace/[workspaceId]/tables/[tableId]/components/table-sidebar-header/table-sidebar-header.tsx

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

docs(ui): describe shared table sidebar exports

9c29e80

vercel Bot temporarily deployed to Preview September 24, 2026 23:25 Inactive

cubic-dev-ai Bot reviewed Sep 24, 2026

View reviewed changes

BillLeoutsakosvl346 merged commit 801329c into codex/control-fix-icon-button-sizing Sep 24, 2026
8 checks passed

waleedlatif1 deleted the codex/control-fix-field-disclosures branch September 24, 2026 23:57

BillLeoutsakosvl346 mentioned this pull request Sep 25, 2026

refactor(ui): centralize compact icon button sizing in EMCN #7991

Open

Conversation

BillLeoutsakosvl346 commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 19, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 21, 2026

Before / after visual comparison

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 22, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot commented Sep 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

Uh oh!

BillLeoutsakosvl346 commented Sep 24, 2026

BillLeoutsakosvl346 commented Sep 19, 2026 •

edited

Loading

vercel Bot commented Sep 19, 2026 •

edited

Loading

greptile-apps Bot commented Sep 19, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading