Skip to content

refactor(ui): use EMCN fields in deployment and setup modals - #8009

Merged
BillLeoutsakosvl346 merged 4 commits into
codex/emcn-consolidationfrom
codex/control-fix-modal-fields
Sep 24, 2026
Merged

BillLeoutsakosvl346 merged 4 commits into
codex/emcn-consolidationfrom
codex/control-fix-modal-fields

Conversation

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor

Replace the remaining flagged field wrappers in Chat deployment, MCP deployment, and the Slack setup wizard with ChipModalField. Reuse its labels, spacing, hints, and errors, and allow custom fields to associate their label with an existing control ID.

The fields adopt EMCN’s muted labels, 9px label/control gaps, and aligned side gutters. Existing input surfaces, corners, textarea minimum heights, Slack input height, native required validation, and form submission remain intact. No new component variants are introduced.

Validation:

  • All 8 modal-field audit findings removed; no new styling findings.
  • EMCN: 351 tests passed; relevant consumer suites: 26 tests passed.
  • All workspace type checks and lint checks passed, along with import resolution and mandatory API validation.
  • Browser verification is incomplete: the local application loads the deployment modal, but Chat and MCP data requests leave its fields in loading states. The Slack wizard was not visually verified. No deployment was submitted during this check.

@vercel

vercel Bot commented Sep 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 24, 2026 10:16pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with no actionable correctness, accessibility, security, or repository-rule failures identified.

Summary

This PR migrates the remaining Chat deployment, MCP deployment, and Slack setup fields to the shared ChipModalField presentation and accessibility model.

  • Adds optional custom-control label association through htmlFor.
  • Preserves controlled values, native required validation, textarea dimensions, and form submission behavior.
  • Aligns labels, hints, errors, and horizontal gutters across the affected modal fields.
  • Adds coverage for custom-field labels, error descriptions, native validation, and Enter behavior.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Consumer[Chat, MCP, or Slack field] --> Field[ChipModalField]
  Field --> Label[Associated muted label]
  Field --> Control[Existing input, textarea, or combobox]
  Field --> Feedback[Hint or error message]
  Feedback --> ARIA[aria-describedby / aria-invalid]
  Label --> Association[htmlFor / control id]
  ARIA --> Control
  Association --> Control
Loading

Reviews (2) · Last reviewed commit: "refactor(ui): use EMCN fields in deploym..."

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

Before / after visual comparison

Chat deployment Title, validation error and Welcome message now use ChipModalField. Labels become muted, field gutters become 8px, and shared label spacing is used; existing input surfaces and the 80px textarea minimum remain.

Left = before; right = after.

Rendered component fixtures with application CSS and local data, rather than authenticated product-page screenshots. These are representative visual examples, not end-to-end behavior coverage.

Fresh isolated render of the chat field compositions; this does not claim live Chat/MCP deployment or Slack setup coverage.

Current PR head checked at posting: 4360284d13.

Before and after: 8009 modal fields

@BillLeoutsakosvl346
BillLeoutsakosvl346 changed the base branch from codex/emcn-consolidation to codex/overrides-chip-sizing September 22, 2026 20:04
@BillLeoutsakosvl346
BillLeoutsakosvl346 force-pushed the codex/control-fix-modal-fields branch 2 times, most recently from 4360284 to cfa8a5c Compare September 22, 2026 20:04
@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@greptile

@BillLeoutsakosvl346

Copy link
Copy Markdown
Contributor Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@BillLeoutsakosvl346 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

Base automatically changed from codex/overrides-chip-sizing to codex/emcn-consolidation September 23, 2026 02:11
Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
@BillLeoutsakosvl346
BillLeoutsakosvl346 merged commit 3821308 into codex/emcn-consolidation Sep 24, 2026
6 checks passed
BillLeoutsakosvl346 added a commit that referenced this pull request Sep 24, 2026
* improvement(emcn): share ordinary action geometry in Button

* improvement(emcn): consolidate selection controls and styling options

* test(emcn): read email geometry from the public export

* improvement(emcn): share larger chip and field geometry (#8151)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): use EMCN fields in deployment and setup modals (#8009)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): share knowledge filter headings (#8073)

* improvement(ui): share knowledge filter headings

* improvement(ui): share inline filter and pagination actions (#8163)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): use chip fields in workflow search and replace (#8076)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): use chip fields in workflow search and replace

* fix(ui): use shared centered chip content on chat errors

* improvement(ui): use chips for ordinary product actions (#8081)

* improvement(ui): use chips for ordinary product actions

* improvement(ui): use shared chip alignment

* improvement(ui): use shared search action sizes (#8160)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse chips for custom block upload actions (#8084)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use native attachment action (#8265)

* fix(chat): use native attachment action

* fix(chat): retain disabled attachment tooltip

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(chat): use EMCN icon button target for attachments

* refactor(ui): centralize destructive ghost button colors in EMCN (#7988)

* improvement(emcn): share larger chip and field geometry

* refactor(ui): use EMCN fields in deployment and setup modals

* refactor(ui): centralize destructive ghost button colors in EMCN

* improvement(ui): use standard knowledge tag icon size

* refactor(ui): consolidate product corner radii

* improvement(ui): reuse chip for PII configuration action (#8173)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share collapsible workflow field cards (#8017)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): compose horizontal and credential fields in EMCN (#8164)

* improvement(ui): compose horizontal and credential fields in EMCN

* Share deploy chat field error treatment (#8255)

* refactor(ui): share deploy chat field error treatment

* refactor(ui): name deploy error props

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share public headings and product typography (#8069)

* improvement(emcn): share larger chip and field geometry

* improvement(ui): share public authentication headings

* improvement(ui): share workflow panel tab buttons (#8072)

* improvement(ui): share workflow panel tab buttons

* improvement(ui): reuse chips for panel selection actions (#8166)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* refactor(ui): share account headings and auth control sizing (#8074)

* improvement(ui): share account status headings

* improvement(ui): use shared sizing for auth controls

* refactor(emcn): share invalid OTP slot treatment (#8246)

* Add shared invalid state to EMCN OTP slots

* fix(ui): distinguish OTP verification from resend errors

* test(ui): type OTP input queries as inputs

* test(ui): import OTP test button prop type

* test(ui): use shared logger mock in OTP regression

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* improvement(ui): share missing resource states (#8078)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* improvement(ui): reuse avatars for owners and members (#8079)

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>

* fix(ui): adopt exact shared 18px typography token

* fix(ui): preserve panel and auth control semantics

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Waleed <walif6@gmail.com>

* fix(ui): preserve shared tag actions and product styling fallbacks

* fix(ui): keep logs filters on canonical chip height

---------

Co-authored-by: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Waleed <walif6@gmail.com>
@waleedlatif1
waleedlatif1 deleted the codex/control-fix-modal-fields branch September 24, 2026 23:58

This branch was successfully deployed

1 active deployment
Preview — 4692d237 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant