Skip to content

SF-3795 Fix draft import dialog broken after locale change - #4231

Merged
Nateowami merged 1 commit into
masterfrom
fix/SF-3795-dialog-direction-broken
Oct 28, 2026
Merged

Nateowami merged 1 commit into
masterfrom
fix/SF-3795-dialog-direction-broken

Conversation

@Nateowami

@Nateowami Nateowami commented Oct 24, 2026 •

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@Nateowami Nateowami added the will require testing PR should not be merged until testers confirm testing is complete label Oct 24, 2026
@Nateowami
Nateowami deployed to screenshot_diff October 24, 2026 03:37 — with GitHub Actions Active
@codecov

codecov Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.22%. Comparing base (b5000ba) to head (36d8825).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...aft-history-entry/draft-history-entry.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4231   +/-   ##
=======================================
  Coverage   81.22%   81.22%           
=======================================
  Files         670      670           
  Lines       42975    42975           
  Branches     7092     7122   +30     
=======================================
  Hits        34905    34905           
  Misses       6921     6921           
  Partials     1149     1149           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@Nateowami Nateowami added the ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes label Oct 24, 2026
@pmachapman
pmachapman self-requested a review October 27, 2026 21:06
@pmachapman pmachapman self-assigned this Oct 27, 2026

@pmachapman pmachapman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@pmachapman reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Nateowami).

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Oct 27, 2026
@Nateowami Nateowami added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Oct 28, 2026
@Nateowami
Nateowami force-pushed the fix/SF-3795-dialog-direction-broken branch from abe9da5 to 36d8825 Compare October 28, 2026 16:43
@Nateowami
Nateowami enabled auto-merge (squash) October 28, 2026 16:45
@Nateowami
Nateowami deployed to screenshot_diff October 28, 2026 16:50 — with GitHub Actions Active
@Nateowami
Nateowami merged commit 2354224 into master Oct 28, 2026
27 checks passed
@Nateowami
Nateowami deleted the fix/SF-3795-dialog-direction-broken branch October 28, 2026 16:53

This branch was successfully deployed

1 active deployment
screenshot_diff — 36d8825a Deployed Oct 28, 2026 by Nateowami via Compare Screenshots #1232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes testing complete Testing of PR is complete and should no longer hold up merging of the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants