Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## task/sec1-9 #4225 +/- ##
============================================
Coverage 81.20% 81.20%
============================================
Files 670 670
Lines 42922 42922
Branches 7088 7117 +29
============================================
Hits 34855 34855
Misses 6919 6919
Partials 1148 1148 ☔ View full report in Codecov by Harness. |
Whether a client's op data is a list of JSON0 components decides both whether the apply middleware reads the op and whether the update is denied, but it was covered only through the ShareDB pipeline. The new tests state the answer for each shape, including a component that names a subtype without carrying the subtype op, which is accepted although JSON0 needs both.
marksvc
marked this pull request as ready for review
October 23, 2026 16:16
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whether a client's op data is a list of JSON0 components decides both
whether
the apply middleware reads the op and whether the update is denied,
but it was
covered only through the ShareDB pipeline. The new tests state the
answer for
each shape, including a component that names a subtype without
carrying the
subtype op, which is accepted although JSON0 needs both.
Open in Devin Review
Stack created with GitHub Stacks CLI • Give Feedback 💬
This change is