Skip to content

rts test: Show what isComponentList accepts and refuses - #4225

Open
marksvc wants to merge 1 commit into
task/sec1-9from
task/sec1-10
Open

marksvc wants to merge 1 commit into
task/sec1-9from
task/sec1-10

Conversation

@marksvc

@marksvc marksvc commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Whether a client's op data is a list of JSON0 components decides both
whether
the apply middleware reads the op and whether the update is denied,
but it was
covered only through the ShareDB pipeline. The new tests state the
answer for
each shape, including a component that names a subtype without
carrying the
subtype op, which is accepted although JSON0 needs both.


Open in Devin Review


Stack created with GitHub Stacks CLI • Give Feedback 💬


This change is Reviewable

@marksvc
marksvc added this pull request to stack #4226 October 22, 2026 21:54
@marksvc marksvc added the e2e Run e2e tests for this pull request label Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (4f2e9e1) to head (460e022).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##           task/sec1-9    #4225   +/-   ##
============================================
  Coverage        81.20%   81.20%           
============================================
  Files              670      670           
  Lines            42922    42922           
  Branches          7088     7117   +29     
============================================
  Hits             34855    34855           
  Misses            6919     6919           
  Partials          1148     1148           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Whether a client's op data is a list of JSON0 components decides both
whether
the apply middleware reads the op and whether the update is denied,
but it was
covered only through the ShareDB pipeline. The new tests state the
answer for
each shape, including a component that names a subtype without
carrying the
subtype op, which is accepted although JSON0 needs both.
@marksvc
marksvc removed this pull request from stack #4226 October 23, 2026 16:11
@marksvc
marksvc added this pull request to stack #4228 October 23, 2026 16:11
@marksvc marksvc added testing not required ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes labels Oct 23, 2026
@marksvc
marksvc marked this pull request as ready for review October 23, 2026 16:16
@marksvc
marksvc deployed to e2e_tests October 23, 2026 16:17 — with GitHub Actions Active
@marksvc
marksvc deployed to e2e_tests October 23, 2026 16:18 — with GitHub Actions Active
@marksvc
marksvc deployed to e2e_tests October 23, 2026 16:18 — with GitHub Actions Active
@marksvc
marksvc deployed to screenshot_diff October 23, 2026 16:19 — with GitHub Actions Active

This branch was successfully deployed

2 active deployments
screenshot_diff — 460e0224 Deployed Oct 23, 2026 by marksvc via Compare Screenshots #1193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-author-sign-off PR author has looked at AI review of change and determined no findings warrant further changes e2e Run e2e tests for this pull request testing not required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant