Repository navigation
SF-3967 Update the translation engine if the engine type changes - #4211
Open
pmachapman wants to merge 1 commit into
Open
pmachapman wants to merge 1 commit into
pmachapman wants to merge 1 commit into
Conversation
pmachapman
added
will require testing
pmachapman
force-pushed
the
fix/SF-3967
branch
from
October 21, 2026 01:35
312b24a to
adb956c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4211 +/- ##
==========================================
- Coverage 81.20% 81.19% -0.01%
==========================================
Files 670 670
Lines 42913 42908 -5
Branches 7105 7080 -25
==========================================
- Hits 34846 34841 -5
- Misses 6902 6919 +17
+ Partials 1165 1148 -17 ☔ View full report in Codecov by Harness. |
Contributor
|
✅ No screenshot differences — all stories are identical. View the diff page at: https://pr-4211--sf-screenshot-diffs.netlify.app |
pmachapman
force-pushed
the
fix/SF-3967
branch
from
October 21, 2026 01:46
adb956c to
0950a29
Compare
RaymondLuong3
approved these changes
Oct 22, 2026
RaymondLuong3
left a comment
RaymondLuong3
left a comment
Collaborator
There was a problem hiding this comment.
That is nice! Thanks for the improvement.
@RaymondLuong3 reviewed 7 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
RaymondLuong3
added
ready to test
testing complete
pmachapman
force-pushed
the
fix/SF-3967
branch
from
October 26, 2026 19:11
0950a29 to
f4c6282
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ads support for a feature on the current version of Serval QA where the translation engine type can be changed from NMT to Echo (and back) without having the build history lost.
I have marked this as do not merge, as the feature is not yet on Serval Production.
This change is