[pmachapman]

This PR adds support for creating docker images by tagging a commit with a tag in the format docker_1.2.3-mytest

---

This change is 

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.20%. Comparing base (a37b256) to head (4861862).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #4131   +/-   ##
=======================================
  Coverage   81.20%   81.20%           
=======================================
  Files         670      670           
  Lines       42913    42913           
  Branches     7111     7081   -30     
=======================================
  Hits        34846    34846           
  Misses       6919     6919           
  Partials     1148     1148           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

[Nateowami]

Sorry this hasn't gotten reviewed in so long. I think I (and perhaps others) are not certain what the intended use-case is for this, and without a clear understanding of the purpose it's hard to review. The title says "Add support for building images from tags starting with docker_". I think the meaning is "Automatically build docker images when a tag starting with docker_ is pushed".

[Nateowami]

@Nateowami made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on pmachapman).

---

.github/workflows/docker-dev.yml line 69 at r1 (raw file):

          file: src/RealtimeServer/Dockerfile
          push: true
          platforms: linux/amd64,linux/arm64

• src/SIL.XForge.Scripture/Dockerfile sets ARG ARCHITECTURE=amd64
• src/RealtimeServer/Dockerfile sets ARG ARCHITECTURE=amd64

I don't know exactly how architectures work in Docker, but I would think these would end up conflicting, and best-case it just wouldn't actually work on arm. But again, I don't really know how this works. Presumably there's a way to update those dockerfiles to support arm

[pmachapman]

I have renamed the PR. The original use case was a discussion we had where you mentioned creating test servers quickly for PRs, an I mentioned using a similar method to what Serval uses (which is tags starting with docker_). This PR is the first step towards having a test server where a PR can be spun up quickly from a Docker image.

@pmachapman made 2 comments.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on Nateowami).

---

.github/workflows/docker-dev.yml line 69 at r1 (raw file):

Previously, Nateowami wrote…

• src/SIL.XForge.Scripture/Dockerfile sets ARG ARCHITECTURE=amd64
• src/RealtimeServer/Dockerfile sets ARG ARCHITECTURE=amd64

I don't know exactly how architectures work in Docker, but I would think these would end up conflicting, and best-case it just wouldn't actually work on arm. But again, I don't really know how this works. Presumably there's a way to update those dockerfiles to support arm

I've updated the Dockerfile's architecture to use the target architecture specified by Docker (and the GHA). I'm sure I tested this on my arm64 Raspberry Pi when I originally created the Dockerfiles, but I am retesting now to ensure everything is OK.

[marksvc]

This is reviewable in Devin Review.

[marksvc]

@marksvc reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Nateowami).