You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Port UsfmUpdateBlock.Rows (replaces Metadata) and the internal UsfmUpdateBlockBuilder
Port the marker placement fixes in PlaceMarkersUsfmUpdateBlockHandler: empty rows are ignored, per-row alignments are merged, out-of-range pairs are rejected, and closing markers can't land before their opening marker
Not ported: the machine.py warning logs, because SIL.Machine has no logging dependency. I also skipped the machine.py tests that only cover that logging and the unaligned-end placement.
Public API change:UsfmUpdateBlock.Metadata and the block's mutator methods are gone. Rows replaces Metadata, and the mutators now live on an internal builder. This matches the machine.py change.
· branch claude/issue-558-20261026-1309
Activity
claude commentedon Oct 26, 2026
Claude finished @Enkidu93's task in 5m 49s —— View job •
claude/issue-558-20261026-1309• [Create PR ➔](https://github.com/sillsdev/machine/compare/master...claude/issue-558-20261026-1309?quick_pull=1&title=Issue%20%23558%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%23558%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)Port of machine.py PR #371 is done
UsfmUpdateBlock.Rows(replacesMetadata) and the internalUsfmUpdateBlockBuilderPlaceMarkersUsfmUpdateBlockHandler: empty rows are ignored, per-row alignments are merged, out-of-range pairs are rejected, and closing markers can't land before their opening marker./local_check.sh --agent-strict→local_check: PASSEDNot ported: the machine.py warning logs, because
SIL.Machinehas no logging dependency. I also skipped the machine.py tests that only cover that logging and the unaligned-end placement.Public API change:
UsfmUpdateBlock.Metadataand the block's mutator methods are gone.RowsreplacesMetadata, and the mutators now live on an internal builder. This matches the machine.py change.· branch
claude/issue-558-20261026-1309