Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hahn-kev
reviewed
Oct 27, 2026
| var localAfter = localClient.Plus(pulledState.GetClientState(localClient.ClientId)); | ||
| var remoteAfter = remoteClient.Plus(pushedState.GetClientState(localClient.ClientId)); | ||
| if (!localAfter.HasSameCommits(remoteAfter)) | ||
| logger.LogWarning("Commits from client {ClientId} will still differ after this sync: local has {LocalCount} up to {LocalHead}, remote has {RemoteCount} up to {RemoteHead}", |
Collaborator
There was a problem hiding this comment.
I'm not sure I care about this specifically, as much as I just want to know when the clients have the same timestamp but not the same hash.
hahn-kev
reviewed
Oct 27, 2026
SyncService now logs a warning when, after this sync, local and remote will still hold different commits from some client: a side withheld commits the other lacks. This catches a case the server can't see, such as a device whose old commit never reached the server while it keeps pushing newer ones, so the server only ever looks "just behind". It compares count and XOR hash of local + pulled against remote + pushed, using commits already in memory, and skips clients where a side sends its whole history, since that resends commits the other side has. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
SyncServicelogs a warning when a sync will leave local and remote holding different commits from some client, i.e. one side withheld commits the other lacks.🤖 Generated with Claude Code