Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
myieye
force-pushed
the
sync-exception
branch
from
October 26, 2026 10:12
67a03e8 to
6b449ed
Compare
hahn-kev
reviewed
Oct 27, 2026
| var pullError = await pullTask; | ||
| var pushError = await pushTask; | ||
| if (pullError is not null || pushError is not null) | ||
| throw new SyncException(missingFromLocal, pullError, missingFromRemote, pushError); |
Collaborator
There was a problem hiding this comment.
is throwing here the right thing? or should we just change the change of SyncResults?
myieye
force-pushed
the
sync-exception
branch
from
October 27, 2026 06:59
6b449ed to
1d2465d
Compare
When applying commits fails, SyncWith and SyncMany now throw a sealed SyncException with PullError, PushError and Applied (the commits that did land), instead of rethrowing the raw error or an AggregateException. Its message names the failed direction, both counts and the underlying errors. Callers can now stamp pushed commits as synced, or process pulled ones, after a partial sync. The contract is documented on ISyncable. Breaking: errors from applying commits no longer reach callers raw. FW Lite's offline check (HttpRequestException or OperationCanceledException around SyncWith) must also look at SyncException.PushError, in the same Lexbox PR that bumps harmony. Errors reading sync state or changes still propagate unwrapped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
myieye
force-pushed
the
sync-exception
branch
from
October 28, 2026 05:47
1d2465d to
c7c23a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Claude, autonomous]
SyncWith/SyncManythrow aSyncExceptionwithPullError,PushErrorandAppliedwhen applying commits fails, instead of the raw error or anAggregateException.SyncException.PushError, so FW Lite's offline check (HttpRequestExceptionorOperationCanceledException) must handle it in the Lexbox PR that bumps Harmony.Appliedyet. The payoff is FW Lite acting on the direction that landed after a partial sync (notifications for pulled commits, stamping pushed ones).🤖 Generated with Claude Code