Repository navigation
Remove dead Mono code from FLExBridgeListener - #1211
Merged
Merged
Conversation
Remove dead Mono code that contains a Mediator call (which we are working on removing). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1211 +/- ##
=======================================
Coverage 40.09% 40.10%
=======================================
Files 1544 1544
Lines 355320 355309 -11
Branches 41359 41357 -2
=======================================
+ Hits 142456 142481 +25
+ Misses 183559 183528 -31
+ Partials 29305 29300 -5
🚀 New features to boost your workflow:
|
thejambi
approved these changes
Oct 28, 2026
thejambi
left a comment
Contributor
There was a problem hiding this comment.
@thejambi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start here:
Src/LexText/Lexicon/FLExBridgeListener.cs-- the whole change is two deleted platform branches.Removes the two branches in
FLExBridgeListenerthat only ran on Mono or Unix:OnFLExLiftBridge(the Send/Receive toolbar button and Ctrl+R) queued the bridge launch on the Mediator'sIdleQueueunder Mono, to work around a Mono bug where the toolbar button held mouse capture while FLEx Bridge blocked the UI thread. Windows already calledRunFLExLiftBridgedirectly; that call is now the only path.OnDisplayCheckForFlexBridgeUpdateshid the Send/Receive > Check for FLEx Bridge Updates... item on Unix. The Windows path (enabled when FLEx Bridge is installed) is now the only path.The unused
SIL.PlatformUtilitiesusing goes with them.What breaks? Nothing on Windows: each handler keeps exactly the branch Windows always took. The point is one fewer Mediator call (an
IdleQueueuse) for the Pub/Sub migration to account for. A scan of every otherPlatform.IsMono/IsUnixcheck underSrcfound no other Mono branch holding a Mediator call or a deferral.Verification
.\build.ps1 -CommentHygiene -TokenHygiene: passed, 0 warnings..\test.ps1 -CommentHygiene -TokenHygiene -TestProject LexEdDllTests: 47/47 passed.Next: approve.
🤖 Generated with Claude Code
This change is