Skip to content

Remove dead Mono code from FLExBridgeListener - #1211

Merged
mark-sil merged 1 commit into
mainfrom
claude/pubsub-flexbridge-direct-launch-014fc9
Oct 28, 2026
Merged

mark-sil merged 1 commit into
mainfrom
claude/pubsub-flexbridge-direct-launch-014fc9

Conversation

@mark-sil

@mark-sil mark-sil commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Start here: Src/LexText/Lexicon/FLExBridgeListener.cs -- the whole change is two deleted platform branches.

Removes the two branches in FLExBridgeListener that only ran on Mono or Unix:

  • OnFLExLiftBridge (the Send/Receive toolbar button and Ctrl+R) queued the bridge launch on the Mediator's IdleQueue under Mono, to work around a Mono bug where the toolbar button held mouse capture while FLEx Bridge blocked the UI thread. Windows already called RunFLExLiftBridge directly; that call is now the only path.
  • OnDisplayCheckForFlexBridgeUpdates hid the Send/Receive > Check for FLEx Bridge Updates... item on Unix. The Windows path (enabled when FLEx Bridge is installed) is now the only path.

The unused SIL.PlatformUtilities using goes with them.

What breaks? Nothing on Windows: each handler keeps exactly the branch Windows always took. The point is one fewer Mediator call (an IdleQueue use) for the Pub/Sub migration to account for. A scan of every other Platform.IsMono / IsUnix check under Src found no other Mono branch holding a Mediator call or a deferral.

Verification

  • .\build.ps1 -CommentHygiene -TokenHygiene: passed, 0 warnings.
  • .\test.ps1 -CommentHygiene -TokenHygiene -TestProject LexEdDllTests: 47/47 passed.
  • No manual test: the removed code never ran on Windows.

Next: approve.

🤖 Generated with Claude Code


This change is Reviewable

Remove dead Mono code that contains a Mediator call (which we are
working on removing).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

NUnit Tests

    1 files  ±0      1 suites  ±0   14m 5s ⏱️ + 2m 40s
6 868 tests ±0  6 783 ✅ ±0  85 💤 ±0  0 ❌ ±0 
6 877 runs  ±0  6 792 ✅ ±0  85 💤 ±0  0 ❌ ±0 

Results for commit 42140f0. ± Comparison against base commit cf3191a.

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.10%. Comparing base (a31e54a) to head (42140f0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
Src/LexText/Lexicon/FLExBridgeListener.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1211   +/-   ##
=======================================
  Coverage   40.09%   40.10%           
=======================================
  Files        1544     1544           
  Lines      355320   355309   -11     
  Branches    41359    41357    -2     
=======================================
+ Hits       142456   142481   +25     
+ Misses     183559   183528   -31     
+ Partials    29305    29300    -5     
Files with missing lines Coverage Δ
Src/LexText/Lexicon/FLExBridgeListener.cs 4.56% <0.00%> (+0.08%) ⬆️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thejambi thejambi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@thejambi reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on mark-sil).

@mark-sil
mark-sil merged commit 5cbbfe8 into main Oct 28, 2026
9 checks passed
@mark-sil
mark-sil deleted the claude/pubsub-flexbridge-direct-launch-014fc9 branch October 28, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants