Skip to content

LT-22802: Show Exception "Features" in the Avalonia detail view #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thejambi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LT-22802: Show Exception "Features" in the Avalonia detail view #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Src/Common/FwAvalonia/FwAvaloniaStrings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,9 @@ public static string StructuredTextParagraphName(string fieldLabel, int paragrap
public static string FeaturePosEditName => Text("FwAvalonia.Feature.PosEditName");
public static string FeaturePosEditDescription => Text("FwAvalonia.Feature.PosEditDescription");

public static string FeatureProdRestrictEditName => Text("FwAvalonia.Feature.ProdRestrictEditName");
public static string FeatureProdRestrictEditDescription => Text("FwAvalonia.Feature.ProdRestrictEditDescription");

/// <summary>The empty-choice label a list chooser leads with when the field allows no value.
/// English must match the legacy launchers' <c>ksNullLabel</c> so both frameworks show the same word.</summary>
public static string ChooserEmptyItemLabel => Text("FwAvalonia.Chooser.EmptyItemLabel");
Expand Down
6 changes: 6 additions & 0 deletions Src/Common/FwAvalonia/FwAvaloniaStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,12 @@
<data name="FwAvalonia.Feature.PosEditDescription" xml:space="preserve">
<value>The Part of Speech editor.</value>
</data>
<data name="FwAvalonia.Feature.ProdRestrictEditName" xml:space="preserve">
<value>Grammar / Exception "Features"</value>
</data>
<data name="FwAvalonia.Feature.ProdRestrictEditDescription" xml:space="preserve">
<value>The Exception "Features" editor.</value>
</data>
<data name="FwAvalonia.Chooser.EmptyItemLabel" xml:space="preserve">
<value>&lt;Empty&gt;</value>
</data>
Expand Down
1 change: 1 addition & 0 deletions Src/Common/FwAvalonia/FwAvaloniaTests/UIFrameworkResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ public void InertFollowUpToolsFallBackToLegacy_UIFramework()
[TestCase("lexiconEdit")]
[TestCase("notebookEdit")]
[TestCase("posEdit")]
[TestCase("ProdRestrictEdit")]
public void BaseDetailEditorTools_StayActive(string tool)
{
Assert.That(UIFrameworkResolver.SupportsAvaloniaForTool(tool), Is.True,
Expand Down
3 changes: 3 additions & 0 deletions Src/Common/FwAvalonia/LexiconFeatureCatalog.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ public static class LexiconFeatureCatalog
FwAvaloniaStrings.FeatureGroupOtherRecordTypes),
new LexiconFeatureDescriptor("posEdit",
FwAvaloniaStrings.FeaturePosEditName, FwAvaloniaStrings.FeaturePosEditDescription,
FwAvaloniaStrings.FeatureGroupOtherRecordTypes),
new LexiconFeatureDescriptor("ProdRestrictEdit",
FwAvaloniaStrings.FeatureProdRestrictEditName, FwAvaloniaStrings.FeatureProdRestrictEditDescription,
FwAvaloniaStrings.FeatureGroupOtherRecordTypes)
};

Expand Down
1 change: 1 addition & 0 deletions Src/xWorks/xWorksTests/Avalonia/Hosting/RecordEditViewSwitchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ public void NonMigratedRecordEditTools_FallBackToLegacy_WhenUIModeIsNew(string t
// adds the corresponding TestCase row here.
[TestCase("notebookEdit")]
[TestCase("posEdit")]
[TestCase("ProdRestrictEdit")]
public void RegisteredRecordEditTools_ResolveToAvalonia_WhenUIModeIsNew(string toolValue)
{
m_propertyTable.SetProperty("UIMode", "New", true);
Expand Down
Loading