[thejambi]

Start here: DetailComposer.WalkSublayout in Src/xWorks/Avalonia/Composer/DetailComposer.cs -- it lays a subrecord's own layout out under its header.

In Notebook > Record Edit in New mode, each subrecord now shows its fields under its header, chosen by its Type as in legacy, and nested subrecords repeat that one level further in (LT-22858). The header reads 1. Observation expanded and 1. Observation - <title> collapsed. The branch also fixes LT-22844: an empty list whose layout names no ghost field no longer shows a "Type to add ..." box that cannot be typed in.

Why did subrecords show nothing? The SubRecord layout brings the fields in with <sublayout name="Normal" layoutChoiceField="Type"/>, which the importer dropped as publishing-only; it is the only detail-view <sublayout>. What disappears with LT-22844? Only rows that could create nothing. Each affected list keeps its section header and that header's Insert command, and working prompts (sense and subsense gloss, a record's Text) stay.

Where to look

• WalkSublayout: the Type choice (ResolveLayoutChoiceGuid) and in-place descent -- Compose_ASubrecord_ShowsItsFields_UnderItsHeader_ChosenByItsType, Compose_ASubrecordOfASubrecord_ShowsItsFieldsOneLevelFurtherIn.
• The Summary case: a subrecord's header stands for its opening summary row and walks that row's children in its place (_itemSummaryHvo) -- Compose_ASubrecord_HasOneHeaderOfItsOwn_UnderTheSubrecordsSection.
• AddGhostPrompt's early return -- Compose_AnEmptyListWithNoGhostField_HasNoPromptRow_UnlessTypingCanCreate, Compose_EmptyAllomorphSection_ShowsOnlyItsHeader_WithInsertOnItsMenu.
• Edits land on the subrecord -- Edit_ASubrecordsTitle_UnderItsHeader_SavesToTheSubrecord.

Not here

• Field Visibility and Move Field on a subrecord's rows target Normal without its Type choice, as on the top-level record.
• The composer's depth cap now allows about 16 subrecord levels (it was four); legacy has no cap.
• Date of Event, Participants and the record-link fields stay unsupported.
• LT-22844 reverses LT-22672: Compose the Allomorphs slice, and the shared detail-view fixes it surfaced #1135's watermarked row on an empty Allomorphs list; that row was never typeable.

Stack and verification. Merges into main, on top of #1201 (merged). Hygiene build clean; suites pass (counts in the preflight section). Checked in FLEx: subrecord fields, and header text in both states. Not yet: the LT-22844 checks in the preflight section.

Next: review WalkSublayout and the prompt rule; this leaves draft once the LT-22844 FLEx checks pass.

---

Reading this a year from now -- start here

LT-22858 is the subrecord half of the Notebook detail view in New mode: before it, each subrecord showed only a header with nothing under it. The subrecord header wording was first written for #1201 (LT-22689) and moved here, because in #1201's build a subrecord header had nothing under it and so could never collapse to show its collapsed line. LT-22844 (the dead "Type to add SubRecords" box) joined this branch during preflight, because composing subrecord layouts made that dead row appear inside every subrecord with no subrecords. No working documents were kept on the branch; the reasoning is below.

Decisions, and why

• <sublayout> imports as its own node kind (ViewNodeKind.Sublayout), carrying the layout name in TargetLayout and the choice field in Field. Both properties already exist on every node, so the override applier, the JSON serializer and every node copy carry them without change.
• The composer reuses the record's own layout choice. WalkSublayout resolves the choice with ResolveLayoutChoiceGuid and compiles with CompileForObject(..., choiceGuid, overrides), exactly as the shown record does, and walks the result at the current depth. The existing (object, layout) visited set stops runaway recursion.
• The two per-compose memos keyed without the choice stay as they are. _itemMenuBindings and _itemRootLabelled only ever see sequence and atomic descents, which still compile with no choice; the comment over them now says so.
• The subrecord header stands for its opening summary row. That row (HeavySummary) is the legacy item header, so the sequence's item header replaces it and its children (the <sublayout>) walk directly under the header rather than a level deeper.
• LT-22844 drops only dead prompts. A prompt row is left out when its layout names no ghost field and nothing could be created from typing. Senses and subsenses keep their gloss prompt (the subsense one approved under LT-22690), and every authored ghost keeps its row.

Surprising findings

• In LT-22689: Drop the Senses banner and word item headers like legacy #1201's build the subrecord collapsed text looked wrong in testing. It was not the text: a header with nothing under it draws no +/- box and ignores clicks (LT-22689: Give detail section headers a +/- box and lasting state #1184), so it never collapsed.
• Of 46 sequences in shipped detail parts, 39 name no ghost field. In legacy none of them shows a prompt row when empty; New mode showed one for all of them, typeable only for senses.

Evidence

Claim	Test
The importer keeps <sublayout>; a nameless one drops with a warning	SublayoutElement_ImportsAsANode_NamingItsLayoutAndChoiceField, SublayoutElement_WithoutAName_IsDroppedWithAWarning
Subrecord header lines	Subrecord_ShowsItsNumberAndType_AndWhileCollapsed_ItsTitle
One header per subrecord	Compose_ASubrecord_HasOneHeaderOfItsOwn_UnderTheSubrecordsSection
Fields chosen by Type, one level under the header	Compose_ASubrecord_ShowsItsFields_UnderItsHeader_ChosenByItsType
Nesting, eight levels deep	Compose_ASubrecordOfASubrecord_ShowsItsFieldsOneLevelFurtherIn, Compose_DeeplyNestedSubrecords_AllShowTheirHeadersAndFields
Edits save to the subrecord	Edit_ASubrecordsTitle_UnderItsHeader_SavesToTheSubrecord
No dead prompt rows; working ones stay	Compose_AnEmptyListWithNoGhostField_HasNoPromptRow_UnlessTypingCanCreate, Compose_EmptyAllomorphSection_ShowsOnlyItsHeader_WithInsertOnItsMenu, Compose_ARecordWithNoSubrecords_KeepsTheSubrecordsHeader_WithNoPromptRow

Mutation checks: breaking the Type choice, the field indent, the importer, and the prompt rule each failed its tests, and restoring the old depth cap of 12 failed the eight-level test.

Preflight review details

Code Review Summary

Branch: LT-22858-subrecord-fields
Base: LT-22689-no-senses-banner (PR #1201, at 15c93cc), which merges into main
Date: 2026-10-23
Review model: Claude Opus 5.5 (Claude Code)
Files changed: 8 against the base (2 commits, plus staged in-review changes); main is
one commit ahead of the base, so both branches want a rebase before merge

Overview

In Notebook > Record Edit in New mode, each subrecord showed only its header: the
SubRecord layout brings the subrecord's fields in with
<sublayout name="Normal" layoutChoiceField="Type"/>, which the layout importer dropped
as a publishing construct (LT-22858). The branch imports <sublayout> as a
ViewNodeKind.Sublayout node, and the composer lays out that layout for the subrecord's
Type in place, so the fields sit one level under the subrecord's header and nested
subrecords repeat the pattern.

It also carries the subrecord header wording moved out of #1201 ("1. Observation"
expanded, "1. Observation - title" collapsed), with the skip of the duplicate SubRecords
header. The collapsed text had looked wrong in #1201's build only because a header with
nothing under it cannot collapse; with the fields under it, it does, and it matches the
WinForms view.

During review the branch also took in LT-22844: an empty list whose layout names no ghost
field no longer shows a "Type to add ..." row that cannot be typed in, as in the WinForms
DataTree. Composing subrecord layouts had made that dead row appear inside every subrecord
with no subrecords.

Tickets: LT-22858 and LT-22844 (both user-visible, testable from an install; keys present
in the commits).

Contract/API Changes

• Added ViewNodeKind.Sublayout (FwAvalonia public enum); TargetLayout names the layout
  and Field names the choice field.
• <sublayout> in any imported layout now becomes a node instead of an Info diagnostic;
  one without a name drops with a Warning under the same sublayout-dropped code. All
  other shipped <sublayout> elements sit in jtview publishing layouts that no detail view
  embeds.
• No serialized format, settings, resource-key, native or COM changes.

Findings

Critical - Must address before merge

None.

Important - Should address before merge

• A dead "SubRecords" prompt row appeared inside every subrecord with no subrecords,
  now that subrecord layouts compose. (fixed during review: LT-22844 added -- AddGhostPrompt
  leaves out a prompt that names no ghost field and can create nothing; tests updated)

Minor - Consider

• The revert brought back an unused using SIL.LCModel.Core.KernelInterfaces; in
  DetailSummaryLines.cs. (fixed during review: removed)
• Field Visibility / Move Field on a subrecord's rows target the Normal layout
  without its Type choice (RecordEditView.TryLocateOverrideTarget compiles with no
  choice). (author: accepted; the top-level record already behaves this way, so this is
  not new; note it in the PR)
• About four levels of subrecord nesting fit under the composer's depth cap of 12
  (each level uses three composer levels); the WinForms view has no limit. (accepted at
  preflight; fixed after review in e437db3: the cap is now 48, about 16 subrecord levels,
  covered by Compose_DeeplyNestedSubrecords_AllShowTheirHeadersAndFields)

Required Validation / Evidence

• ./build.ps1 -BuildTests -SkipNative -CommentHygiene -TokenHygiene: clean after the
  in-review changes.
• ./test.ps1 -NoBuild -TestProject xWorksTests -TestFilter 'FullyQualifiedName!~UiaSmokeTests':
  1844 total, 1842 passed, 2 skipped, with the LT-22844 change in place, after rebasing onto
  LT-22689: Drop the Senses banner and word item headers like legacy #1201's review follow-up.
• Affected tests after restoring the LT-22844 rule: 64 of 64 passed (summary lines,
  allomorph section, prompt-row and Lexicon menu tests).
• ./test.ps1 -NoBuild -TestProject FwAvaloniaTests: 937 total, 936 passed, 1 skipped,
  after the rebase.
• Mutation checks: breaking the Type choice, the field indent, the importer, and the
  LT-22844 rule each failed their tests.
• Manual, by the author in FLEx: subrecord fields under their headers, and the
  expanded and collapsed header text matching the WinForms view.
• Manual, not yet done (LT-22844): an empty new notebook record and a subrecord with no
  subrecords show no "SubRecords" box; an entry with no allomorphs shows only the
  Allomorphs header with Insert Allomorph; a part of speech with empty sections shows only
  their headers; an entry with no senses and a sense with no subsenses still show their
  working gloss rows.

Positive Observations

• The fix reuses the composer's existing pieces: the layout choice the root record already
  uses, in-place descent, and the (object, layout) recursion guard.
• Every shipped detail list that loses its dead row keeps its section header, and that
  header carries the same Insert menu.
• The working sense and subsense gloss rows, which name no ghost field but can create a
  sense, are kept and tested.

Interview Notes

• Dead "SubRecords" row: the author chose to fix LT-22844 on this branch.
• LT-22844 reverses a choice from LT-22672 (LT-22672: Compose the Allomorphs slice, and the shared detail-view fixes it surfaced #1135), whose test said an empty Allomorphs
  list "offers the watermarked add row rather than nothing". That row was never typeable;
  the WinForms view shows only the Allomorphs header. Both tests that asserted the dead row
  were rewritten.
• Minors: unused using fixed; override targeting and nesting depth accepted, to be noted
  in the PR.
• Author does not understand: how a subrecord's fields are chosen by its Type and placed
  one level under its header (WalkSublayout with ResolveLayoutChoiceGuid, and the
  Summary case walking the skipped row's children at the header's child depth).
• Nothing else flagged.

In-Review Quality Check

• DetailComposer.AddGhostPrompt: returns before adding a row when the layout names no
  ghost field and ResolveGhostCreation found nothing to create.
• DetailSummaryLines.cs: unused using removed.
• Tests: Compose_EmptyAllomorphSection_ShowsGhostAddRow became
  Compose_EmptyAllomorphSection_ShowsOnlyItsHeader_WithInsertOnItsMenu;
  Compose_GhostWithoutGhostField_IsNotEditable_SoTypingCannotCreateAndDiscard became
  Compose_AnEmptyListWithNoGhostField_HasNoPromptRow_UnlessTypingCanCreate; added
  Compose_ARecordWithNoSubrecords_KeepsTheSubrecordsHeader_WithNoPromptRow.
• Committed as an LT-22844 commit and a small cleanup commit, after rebasing onto LT-22689: Drop the Senses banner and word item headers like legacy #1201's
  review follow-up (15c93cc). Hygiene build and the test runs above are on that tree.

Suggested Review Focus

• DetailComposer.WalkSublayout, and the Summary case walking the skipped summary
  row's children at the header's child depth.
• AddGhostPrompt's new early return, against the lists it removes rows from in the
  four New-mode tools (Lexicon Edit, its popup, Notebook Record Edit, Grammar's
  part-of-speech editor).
• The importer's <sublayout> handling and its effect on the shipped-layout coverage
  report.

🤖 Generated with Claude Code

---

This change is 

[github-actions]

NUnit Tests

    1 files  ±0      1 suites  ±0   14m 12s ⏱️ + 3m 25s
6 840 tests +8  6 755 ✅ +8  85 💤 ±0  0 ❌ ±0 
6 849 runs  +8  6 764 ✅ +8  85 💤 ±0  0 ❌ ±0 

Results for commit e437db3. ± Comparison against base commit c734bff.

This pull request removes 3 and adds 11 tests. Note that renamed tests count towards both.

FwAvaloniaTests.XmlLayoutImporterDropDiagnosticsTests ‑ SublayoutElement_RaisesInfoDropDiagnostic
SIL.FieldWorks.XWorks.AllomorphSectionCompositionTests ‑ Compose_EmptyAllomorphSection_ShowsGhostAddRow
SIL.FieldWorks.XWorks.DetailComposerTests ‑ Compose_GhostWithoutGhostField_IsNotEditable_SoTypingCannotCreateAndDiscard

FwAvaloniaTests.XmlLayoutImporterDropDiagnosticsTests ‑ SublayoutElement_ImportsAsANode_NamingItsLayoutAndChoiceField
FwAvaloniaTests.XmlLayoutImporterDropDiagnosticsTests ‑ SublayoutElement_WithoutAName_IsDroppedWithAWarning
SIL.FieldWorks.XWorks.AllomorphSectionCompositionTests ‑ Compose_EmptyAllomorphSection_ShowsOnlyItsHeader_WithInsertOnItsMenu
SIL.FieldWorks.XWorks.DetailComposerTests ‑ Compose_AnEmptyListWithNoGhostField_HasNoPromptRow_UnlessTypingCanCreate
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Compose_ARecordWithNoSubrecords_KeepsTheSubrecordsHeader_WithNoPromptRow
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Compose_ASubrecordOfASubrecord_ShowsItsFieldsOneLevelFurtherIn
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Compose_ASubrecord_HasOneHeaderOfItsOwn_UnderTheSubrecordsSection
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Compose_ASubrecord_ShowsItsFields_UnderItsHeader_ChosenByItsType
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Compose_DeeplyNestedSubrecords_AllShowTheirHeadersAndFields
SIL.FieldWorks.XWorks.DetailSummaryLinesTests ‑ Edit_ASubrecordsTitle_UnderItsHeader_SavesToTheSubrecord
…

♻️ This comment has been updated with latest results.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.94%. Comparing base (c734bff) to head (e437db3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
Src/xWorks/Avalonia/Composer/DetailComposer.cs	87.09%	2 Missing and 2 partials ⚠️
Src/xWorks/Avalonia/Composer/DetailSummaryLines.cs	75.00%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1203      +/-   ##
==========================================
+ Coverage   39.93%   39.94%   +0.01%     
==========================================
  Files        1542     1542              
  Lines      355165   355217      +52     
  Branches    41317    41329      +12     
==========================================
+ Hits       141833   141896      +63     
+ Misses     183999   183985      -14     
- Partials    29333    29336       +3     

Files with missing lines	Coverage Δ
...n/FwAvalonia/ViewDefinition/ViewDefinitionModel.cs	89.59% <ø> (ø)
...mon/FwAvalonia/ViewDefinition/XmlLayoutImporter.cs	86.63% <100.00%> (+0.14%)	⬆️
Src/xWorks/Avalonia/Composer/DetailComposer.cs	71.93% <87.09%> (+0.80%)	⬆️
Src/xWorks/Avalonia/Composer/DetailSummaryLines.cs	82.66% <75.00%> (-2.34%)	⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mark-sil]

LGTM

[thejambi]

@thejambi reviewed 4 files and all commit messages, resolved 1 discussion, and dismissed @mark-sil from a discussion.
Reviewable status: 0 of 8 files reviewed, all discussions resolved (waiting on mark-sil).