Repository navigation
Conversation
Copy <summary>s from FAS.cs to <comment>s in FAS.resx. REVIEW: not all of the context is relevant. Much is helpful. Is any confusing?
4a9653f to
4ad3d1f
Compare
NUnit Tests 1 files ± 0 1 suites ±0 8m 21s ⏱️ - 2m 1s Results for commit 0de7a83. ± Comparison against base commit a90754c. This pull request removes 28 and adds 273 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1178 +/- ##
==========================================
+ Coverage 39.49% 39.94% +0.44%
==========================================
Files 1537 1542 +5
Lines 354392 355217 +825
Branches 41058 41329 +271
==========================================
+ Hits 139974 141887 +1913
+ Misses 185044 183993 -1051
+ Partials 29374 29337 -37 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on papeh).
The comments carried over from the doc comments named classes, used code markup that Crowdin shows as literal text, and in a few places described the wrong control. They now say what each string is and where it appears. - AudioRecordingReadOnly is a tooltip, not a placeholder. - LaunchDialog and LauncherUnavailable belong to the settings gear. - CharacterStyle, WritingSystem, Link and DeleteEmbeddedObject are right-click menu items, not buttons. - Chooser.EmptyItemLabel asks translators to match "<Empty>" in the WinForms choosers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
To your question: the confusing parts were implementation notes carried over from the doc comments, so I pushed 0de7a83 to reword them for translators instead of leaving suggestions. Each comment now says what the string is and where it appears, without class names (PopupTreeManager, ShortSoundFieldControl, ORC, TsString), A few comments also described the wrong control: This comment was assisted by Claude Opus 5.5. |
Copy
<summary>s from FAS.cs to<comment>s in FAS.resx for inclusion in Crowdin context. Both screen-reader strings' contexts were missing important details that were present in their summaries. Several other strings had summaries that would be helpful for localizers.REVIEW: not all of the context is relevant. Much is helpful. Is any confusing?
Co-authored-by: Copilot (Chat GPT)
This change is
Devin