Repository navigation
fix(mcp): resolve namespace-relative dotted tool searches - #88
Merged
Merged
Conversation
Owner
Author
|
Independent review: Claude Opus 5.5, high effort, via the requested Cursor pool reviewed f11eccd and approved with no blockers. It independently ran both focused local MCP search scenarios: 2/2 passed. Follow-up addresses its nonblocking coverage suggestion with an ambiguous full/relative path fixture; mutation verification (relative-first lookup) failed at the expected wrong-tool assertion, then both scenarios passed after restoration. The comment nit is fixed. No production implementation changed after review. Format, actionlint and bun run check (all nine typecheck projects) passed again. No merge or deployment performed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes product feedback
pc_e17b535fb960:search({ namespace: "m365-admin", query: "tenants.list" })now uses the existing scoped exact lookup, just like the fully qualified path.<canonical namespace>.<query>only for dotted identifier paths.belowfiltering, unavailable-listing handling and exact-match pagination.searchandexecutediscovery, noisy list tools, canonical/expression namespaces, full paths/expressions, bare words, multi-word and malformed/missing paths, pagination, nested scope mismatch and restricted OAuth tool access.Verification
origin/v2: relative query returned five items instead of the single exact tool.bun run e2e:preparepassed.bun run e2e:local --test-name 'MCP search resolves namespace-relative dotted paths|A broad MCP tool search returns concise pages': 2 passed.bun run format;bun run check: passed, including all nine typecheck projects and E2E boundary checks (existing Effect warnings only).actionlint .github/workflows/fork-ci.yml: passed.Boundary
Fork PR targeting
shuv1337/executor:v2only. Do not merge or deploy as part of this task. Opus 5.5/high independently reviewedf11eccd15: approve, no blockers, and reran both named E2Es (2 passed). Its nonblocking precedence-coverage gap is now addressed with a colliding full/relative-path fixture: temporarily reversing candidate order fails on the wrong tool identity; restored order passes. The comment capitalization nit is fixed. No runtime implementation changed after review.bun run check, format, actionlint and both named E2Es passed again on the follow-up.